Avoid planar YUV resources when one component EGL images are not supported

cc/resources/resource_provider.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/resources/resource_provider.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <algorithm>
@@ skipping 427 matching lines @@
   DCHECK(!texture_id_allocator_);
   DCHECK(!buffer_id_allocator_);
 
   const auto& caps = compositor_context_provider_->ContextCapabilities();
 
   DCHECK(IsGpuResourceType(default_resource_type_));
   use_texture_storage_ext_ = caps.texture_storage;
   use_texture_format_bgra_ = caps.texture_format_bgra8888;
   use_texture_usage_hint_ = caps.texture_usage;
   use_compressed_texture_etc1_ = caps.texture_format_etc1;
   yuv_resource_format_ = caps.texture_rg ? RED_8 : LUMINANCE_8;

[danakj, 2016/08/25 01:25:39]

Theres now 3 places in a row that set yuv_highbit_resource_format_, and 2 that
set yuv_resource_format_.

Can you adjust this code with if/elseif/elses so that each of these is set a
single time?

[Tobias Sargeant, 2016/08/26 15:52:11]

Done.

   yuv_highbit_resource_format_ = yuv_resource_format_;
   if (caps.texture_half_float_linear)
     yuv_highbit_resource_format_ = LUMINANCE_F16;
+  if (caps.force_software_yuv_conversion)
+    yuv_resource_format_ = yuv_highbit_resource_format_ = RGBA_8888;
   use_sync_query_ = caps.sync_query;
 
   GLES2Interface* gl = ContextGL();
 
   max_texture_size_ = 0;  // Context expects cleared value.
   gl->GetIntegerv(GL_MAX_TEXTURE_SIZE, &max_texture_size_);
   best_texture_format_ =
       PlatformColor::BestSupportedTextureFormat(use_texture_format_bgra_);
 
   best_render_buffer_format_ = PlatformColor::BestSupportedTextureFormat(
@@ skipping 1553 matching lines @@
 
     const int kImportance = 2;
     pmd->CreateSharedGlobalAllocatorDump(guid);
     pmd->AddOwnershipEdge(dump->guid(), guid, kImportance);
   }
 
   return true;
 }
 
 }  // namespace cc