Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Unified Diff: net/quic/core/quic_protocol_test.cc

Issue 2242423002: Disable QUIC versions less than v32, protected by --FLAGS_quic_disable_pre_32. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@130124951
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/quic_protocol.cc ('k') | net/tools/quic/end_to_end_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/quic_protocol_test.cc
diff --git a/net/quic/core/quic_protocol_test.cc b/net/quic/core/quic_protocol_test.cc
index deee2839823534ca887a92545e808644752ee809..17c289f20f6a9dd97b0fb07acf71ec9516b2ec75 100644
--- a/net/quic/core/quic_protocol_test.cc
+++ b/net/quic/core/quic_protocol_test.cc
@@ -288,16 +288,15 @@ TEST(QuicProtocolTest, FilterSupportedVersions) {
QUIC_VERSION_30, QUIC_VERSION_31, QUIC_VERSION_32, QUIC_VERSION_33,
QUIC_VERSION_34, QUIC_VERSION_35, QUIC_VERSION_36};
+ FLAGS_quic_disable_pre_32 = true;
FLAGS_quic_enable_version_35 = false;
FLAGS_quic_enable_version_36_v2 = false;
QuicVersionVector filtered_versions = FilterSupportedVersions(all_versions);
- ASSERT_EQ(5u, filtered_versions.size());
- EXPECT_EQ(QUIC_VERSION_30, filtered_versions[0]);
- EXPECT_EQ(QUIC_VERSION_31, filtered_versions[1]);
- EXPECT_EQ(QUIC_VERSION_32, filtered_versions[2]);
- EXPECT_EQ(QUIC_VERSION_33, filtered_versions[3]);
- EXPECT_EQ(QUIC_VERSION_34, filtered_versions[4]);
+ ASSERT_EQ(3u, filtered_versions.size());
+ EXPECT_EQ(QUIC_VERSION_32, filtered_versions[0]);
+ EXPECT_EQ(QUIC_VERSION_33, filtered_versions[1]);
+ EXPECT_EQ(QUIC_VERSION_34, filtered_versions[2]);
}
TEST(QuicProtocolTest, QuicVersionManager) {
« no previous file with comments | « net/quic/core/quic_protocol.cc ('k') | net/tools/quic/end_to_end_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698