Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1105)

Unified Diff: runtime/vm/compiler.cc

Issue 22424008: Changes the flag for using far branches from static to volatile. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/compiler.cc
===================================================================
--- runtime/vm/compiler.cc (revision 25961)
+++ runtime/vm/compiler.cc (working copy)
@@ -260,8 +260,8 @@
// while loop, done is set to true. use_far_branches is always false on ia32
// and x64.
bool done = false;
- // static to evade gcc's longjmp variable smashing checks.
- static bool use_far_branches = false;
+ // volatile because the variable may be clobbered by a longjmp.
+ volatile bool use_far_branches = false;
while (!done) {
const intptr_t prev_deopt_id = isolate->deopt_id();
isolate->set_deopt_id(0);
@@ -576,7 +576,6 @@
isolate->set_long_jump_base(old_base);
isolate->set_deopt_id(prev_deopt_id);
}
- use_far_branches = false;
return is_compiled;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698