Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2242363002: [M53] Bound total pixels in JBig2 images to avoid overflows later. (Closed)

Created:
4 years, 4 months ago by Tom Sepez
Modified:
4 years, 4 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@2785
Target Ref:
refs/heads/chromium/2785
Project:
pdfium
Visibility:
Public.

Description

[M53] Bound total pixels in JBig2 images to avoid overflows later. Also make these private to ensure they aren't modified so as to violate the bounds checks applied at creation time. BUG=633002 TBR=thestig@chromium.org Review-Url: https://codereview.chromium.org/2202013002 (cherry picked from commit e21501d9427539828b5d547b9d20a752d06914aa) Committed: https://pdfium.googlesource.com/pdfium/+/1018584aeb1d9f44a40b43b2a5ae1a557a3c442d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+214 lines, -99 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M core/fxcodec/jbig2/JBig2_Context.cpp View 6 chunks +7 lines, -7 lines 0 comments Download
M core/fxcodec/jbig2/JBig2_GrdProc.cpp View 10 chunks +11 lines, -11 lines 0 comments Download
M core/fxcodec/jbig2/JBig2_GrrdProc.cpp View 3 chunks +10 lines, -10 lines 0 comments Download
M core/fxcodec/jbig2/JBig2_Image.h View 3 chunks +11 lines, -15 lines 0 comments Download
M core/fxcodec/jbig2/JBig2_Image.cpp View 2 chunks +60 lines, -47 lines 0 comments Download
A core/fxcodec/jbig2/JBig2_Image_unittest.cpp View 1 chunk +105 lines, -0 lines 0 comments Download
M core/fxcodec/jbig2/JBig2_SddProc.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxcodec/jbig2/JBig2_TrdProc.cpp View 4 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
Tom Sepez
Committed patchset #1 (id:1) manually as 1018584aeb1d9f44a40b43b2a5ae1a557a3c442d (presubmit successful).
4 years, 4 months ago (2016-08-15 21:23:40 UTC) #4
Lei Zhang
4 years, 4 months ago (2016-08-15 21:24:15 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698