Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(860)

Issue 2242353002: [ios] Put autofill scripts into anonymous function. (Closed)

Created:
4 years, 4 months ago by Eugene But (OOO till 7-30)
Modified:
4 years, 4 months ago
Reviewers:
Justin Donnelly
CC:
chromium-reviews, rouslan+autofill_chromium.org, estade+watch_chromium.org, vabr+watchlistautofill_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Put autofill scripts into anonymous function. WKWebView returns NSError if script evaluation result type is not supported. Since all scripts are wrapped into anonymous function, autofill should be wrapped too. BUG=None Committed: https://crrev.com/f98c6e47937e14eab3786c13f25bd403580b0a48 Cr-Commit-Position: refs/heads/master@{#412550}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M components/autofill/ios/browser/resources/autofill_controller.js View 2 chunks +5 lines, -0 lines 0 comments Download
M components/autofill/ios/browser/resources/suggestion_controller.js View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Eugene But (OOO till 7-30)
4 years, 4 months ago (2016-08-15 21:19:52 UTC) #2
Justin Donnelly
lgtm
4 years, 4 months ago (2016-08-17 14:23:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2242353002/1
4 years, 4 months ago (2016-08-17 15:30:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-17 16:19:46 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 16:21:28 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f98c6e47937e14eab3786c13f25bd403580b0a48
Cr-Commit-Position: refs/heads/master@{#412550}

Powered by Google App Engine
This is Rietveld 408576698