Subzero: Replace global pointers to allocation functions

Subzero: Replace global pointers to allocation functions

BUG=https://bugs.chromium.org/p/nativeclient/issues/detail?id=4374
R=kschimpf@google.com, stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=9a313a8d09d1c7fa4c499fdc14fa3ef1332896d6

[tlively, 2016-08-15 21:28:15]

tlively@google.com changed reviewers:
+ kschimpf@google.com, mcgrathr@chromium.org, stichnot@chromium.org

[Karl, 2016-08-15 21:43:46]

https://codereview.chromium.org/2242243003/diff/1/tests_lit/asan_tests/global...
File tests_lit/asan_tests/globalreplacement.ll (right):

https://codereview.chromium.org/2242243003/diff/1/tests_lit/asan_tests/global...
tests_lit/asan_tests/globalreplacement.ll:16: @global_free = internal global i32
ptrtoint (void (i32)* @free to i32)
How about inserting a non-global pointer to show nothing happens.

Also how about one case where there is more than one initializer.

[tlively, 2016-08-15 22:24:59]

https://codereview.chromium.org/2242243003/diff/1/tests_lit/asan_tests/global...
File tests_lit/asan_tests/globalreplacement.ll (right):

https://codereview.chromium.org/2242243003/diff/1/tests_lit/asan_tests/global...
tests_lit/asan_tests/globalreplacement.ll:16: @global_free = internal global i32
ptrtoint (void (i32)* @free to i32)
On 2016/08/15 21:43:46, Karl wrote:
> How about inserting a non-global pointer to show nothing happens.
> 
> Also how about one case where there is more than one initializer.

My next task is to instrument non-global pointers, but I added a global pointer
to a non-allocation function to show that nothing happens to it.

[Karl, 2016-08-16 17:43:32]

lgtm

[Jim Stichnoth, 2016-08-16 17:54:55]

lgtm

https://codereview.chromium.org/2242243003/diff/40001/src/IceASanInstrumentat...
File src/IceASanInstrumentation.cpp (right):

https://codereview.chromium.org/2242243003/diff/40001/src/IceASanInstrumentat...
src/IceASanInstrumentation.cpp:115: if (!Global->hasNonzeroInitializer()) {
I prefer to structure these things like this:

  if (C) A; else B;

instead of:

  if (!C) B; else A;

https://codereview.chromium.org/2242243003/diff/40001/src/IceASanInstrumentat...
src/IceASanInstrumentation.cpp:153: PrototypeMap::iterator SubstProtoEntry =
Optional: I'm usually happy to use "auto" instead of "XXX::iterator".

[tlively, 2016-08-16 18:34:11]

Description was changed from

==========
Subzero: Replace global pointers to allocation functions

BUG=https://bugs.chromium.org/p/nativeclient/issues/detail?id=4374
==========

to

==========
Subzero: Replace global pointers to allocation functions

BUG=https://bugs.chromium.org/p/nativeclient/issues/detail?id=4374
R=kschimpf@google.com, stichnot@chromium.org

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[tlively, 2016-08-16 18:34:13]

Committed patchset #3 (id:40001) manually as
9a313a8d09d1c7fa4c499fdc14fa3ef1332896d6 (presubmit successful).