Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2242243002: Revert of Include generated EffectiveConnectionType.java in cronet api jar and JavaDoc (Closed)

Created:
4 years, 4 months ago by Bret
Modified:
4 years, 4 months ago
Reviewers:
kapishnikov, mef, xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Include generated EffectiveConnectionType.java in cronet api jar and JavaDoc (patchset #5 id:120001 of https://codereview.chromium.org/2234113002/ ) Reason for revert: compile failed on Android Arm64: FAILED: gen/components/cronet/android/generate_javadoc.d python ../../components/cronet/tools/generate_javadoc.py --output-dir cronet --input-dir ../../components/cronet --overview-file cronet/README.md.html --readme-file ../../components/cronet/README.md --depfile gen/components/cronet/android/generate_javadoc.d --lib-java-dir lib.java/components/cronet/android --input-src-jar cronet/cronet_api-src.jar Traceback (most recent call last): File "../../components/cronet/tools/generate_javadoc.py", line 85, in <module> sys.exit(main()) File "../../components/cronet/tools/generate_javadoc.py", line 73, in main GenerateJavadoc(options, os.path.abspath(unzipped_jar_path)) File "../../components/cronet/tools/generate_javadoc.py", line 48, in GenerateJavadoc raise build_utils.CalledProcessError(working_dir, javadoc_cmd, stdout) Original issue's description: > Include generated EffectiveConnectionType.java in cronet api jar and JavaDoc > > This CL includes the EffectiveConnectionType.java in cronet > api jar and in JavaDoc, since that is a part of Cronet API. > > BUG=634092 > > Committed: https://crrev.com/cfb2180def7b0e17bd4dce2bc8300fb4ea02e4ba > Cr-Commit-Position: refs/heads/master@{#411977} TBR=mef@chromium.org,kapishnikov@chromium.org,xunjieli@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=634092 Committed: https://crrev.com/f84d14ad945d5cc3d945bf4df0d9ca9e82824ed7 Cr-Commit-Position: refs/heads/master@{#411980}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -57 lines) Patch
M components/cronet/android/BUILD.gn View 2 chunks +0 lines, -16 lines 0 comments Download
M components/cronet/tools/generate_javadoc.py View 5 chunks +3 lines, -14 lines 0 comments Download
M components/cronet/tools/jar_src.py View 3 chunks +0 lines, -27 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Bret
Created Revert of Include generated EffectiveConnectionType.java in cronet api jar and JavaDoc
4 years, 4 months ago (2016-08-15 17:57:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2242243002/1
4 years, 4 months ago (2016-08-15 17:58:19 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-15 17:59:14 UTC) #5
xunjieli
Thanks for catching the breakage. Do you have a link to the failed build? Thanks.
4 years, 4 months ago (2016-08-15 18:02:09 UTC) #6
Bret
On 2016/08/15 18:02:09, xunjieli wrote: > Thanks for catching the breakage. Do you have a ...
4 years, 4 months ago (2016-08-15 18:03:37 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-15 18:07:06 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f84d14ad945d5cc3d945bf4df0d9ca9e82824ed7
Cr-Commit-Position: refs/heads/master@{#411980}

Powered by Google App Engine
This is Rietveld 408576698