Chromium Code Reviews
DescriptionRevert of Include generated EffectiveConnectionType.java in cronet api jar and JavaDoc (patchset #5 id:120001 of https://codereview.chromium.org/2234113002/ )
Reason for revert:
compile failed on Android Arm64:
FAILED: gen/components/cronet/android/generate_javadoc.d
python ../../components/cronet/tools/generate_javadoc.py --output-dir cronet --input-dir ../../components/cronet --overview-file cronet/README.md.html --readme-file ../../components/cronet/README.md --depfile gen/components/cronet/android/generate_javadoc.d --lib-java-dir lib.java/components/cronet/android --input-src-jar cronet/cronet_api-src.jar
Traceback (most recent call last):
File "../../components/cronet/tools/generate_javadoc.py", line 85, in <module>
sys.exit(main())
File "../../components/cronet/tools/generate_javadoc.py", line 73, in main
GenerateJavadoc(options, os.path.abspath(unzipped_jar_path))
File "../../components/cronet/tools/generate_javadoc.py", line 48, in GenerateJavadoc
raise build_utils.CalledProcessError(working_dir, javadoc_cmd, stdout)
Original issue's description:
> Include generated EffectiveConnectionType.java in cronet api jar and JavaDoc
>
> This CL includes the EffectiveConnectionType.java in cronet
> api jar and in JavaDoc, since that is a part of Cronet API.
>
> BUG=634092
>
> Committed: https://crrev.com/cfb2180def7b0e17bd4dce2bc8300fb4ea02e4ba
> Cr-Commit-Position: refs/heads/master@{#411977}
TBR=mef@chromium.org,kapishnikov@chromium.org,xunjieli@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=634092
Committed: https://crrev.com/f84d14ad945d5cc3d945bf4df0d9ca9e82824ed7
Cr-Commit-Position: refs/heads/master@{#411980}
Patch Set 1 #
Messages
Total messages: 9 (3 generated)
|
|||||||||||||||||||||||||||||||||||||