third_party/WebKit/LayoutTests/http/tests/preload/meta-csp.html - Issue 2242223003: Preload tokens even if a <meta> csp tag is found

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/preload/meta-csp.html

Issue 2242223003: Preload tokens even if a <meta> csp tag is found (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: less refactoring Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/parser/BackgroundHTMLParser.h » ('j') | third_party/WebKit/Source/core/html/parser/BackgroundHTMLParser.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <meta http-equiv="Content-Security-Policy" content="script-src 'self' 'unsafe-in line'; font-src 'none'">
	Mike West 2016/08/19 09:25:41 Can you add a more complicated test as well? Somet Can you add a more complicated test as well? Something like: ``` <meta [policy1]> <script> <meta [policy2]> <script> <meta [policy3]> <link> ```
	3 <script>

	4 var boundedStart = performance.now();

	5 </script>

	6 <script src="../resources/testharness.js"></script>

	7 <script src="../resources/testharnessreport.js"></script>

	8 <link rel=preload href="../resources/Ahem.ttf" as=font crossorigin>

	9 <script>

	10 var t = async_test("Ensure preloads occur when csp meta tags are in the markup ");

	11 window.addEventListener("load", t.step_func(function() {

	12 var fonts = performance.getEntriesByName(new URL("../resources/Ahem.ttf", lo cation.href).href);

	13 assert_equals(fonts.length, 0);

	14 window.performance.getEntriesByType('resource').forEach(function(r) {

	15 if (r.name.indexOf('testharness.js') != -1) {

	16 assert_greater_than(r.startTime, 0);

	17 assert_greater_than(boundedStart, r.startTime);
	kouhei (in TOK) 2016/08/19 04:56:15 Should we use internals.isPreloaded? Should we use internals.isPreloaded? Charlie Harrison 2016/08/19 15:13:40 Done. isPreloaded will return true even if the res Show quoted text On 2016/08/19 04:56:15, kouhei wrote: > Should we use internals.isPreloaded? Done. isPreloaded will return true even if the resource wasn't used, right? kouhei (in TOK) 2016/08/22 05:34:03 Yes. Show quoted text On 2016/08/19 15:13:40, Charlie Harrison wrote: > On 2016/08/19 04:56:15, kouhei wrote: > > Should we use internals.isPreloaded? > > Done. isPreloaded will return true even if the resource wasn't used, right? Yes.
	18 t.done();

	19 }

	20 });

	21 }));

	22 </script>

	23

OLD	NEW