Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1095)

Issue 2242223002: PPC: Enable unaligned access and clean up the use of UNALIGNED_ACCESSES (Closed)

Created:
4 years, 4 months ago by Sampson
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Enable unaligned access and clean up the use of UNALIGNED_ACCESSES BUG= R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com, bjaideep@ca.ibm.com, bmeurer@chromium.org, mstarzinger@chromium.org Committed: https://crrev.com/06520ec22046113edf1a005329fce5d7bd27bc72 Cr-Commit-Position: refs/heads/master@{#38728}

Patch Set 1 #

Patch Set 2 : Replace emit call with X-Form for readability #

Total comments: 2

Patch Set 3 : Reorder new intruction codes in constant-ppc.h #

Patch Set 4 : Rebase over master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -56 lines) Patch
M src/interpreter/interpreter-assembler.cc View 1 2 3 1 chunk +2 lines, -3 lines 0 comments Download
M src/ppc/assembler-ppc.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/ppc/assembler-ppc.cc View 1 1 chunk +15 lines, -0 lines 0 comments Download
M src/ppc/constants-ppc.h View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 1 chunk +3 lines, -44 lines 0 comments Download
M src/regexp/ppc/regexp-macro-assembler-ppc.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/regexp/ppc/regexp-macro-assembler-ppc.cc View 2 chunks +36 lines, -8 lines 0 comments Download

Messages

Total messages: 24 (17 generated)
Sampson
Please take a look.
4 years, 4 months ago (2016-08-15 20:47:13 UTC) #7
JaideepBajwa
https://codereview.chromium.org/2242223002/diff/20001/src/ppc/constants-ppc.h File src/ppc/constants-ppc.h (right): https://codereview.chromium.org/2242223002/diff/20001/src/ppc/constants-ppc.h#newcode149 src/ppc/constants-ppc.h:149: EXT4 = 63 << 26, // Extended code set ...
4 years, 4 months ago (2016-08-15 21:06:52 UTC) #8
JaideepBajwa
lgtm
4 years, 4 months ago (2016-08-16 16:59:15 UTC) #9
Michael Starzinger
LGTM on changes to interpreter.
4 years, 4 months ago (2016-08-18 15:11:27 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2242223002/60001
4 years, 4 months ago (2016-08-18 17:03:44 UTC) #20
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 4 months ago (2016-08-18 17:22:24 UTC) #22
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 17:22:43 UTC) #24
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/06520ec22046113edf1a005329fce5d7bd27bc72
Cr-Commit-Position: refs/heads/master@{#38728}

Powered by Google App Engine
This is Rietveld 408576698