Try to use bot_update in Skia repo recipes

infra/bots/recipe_modules/core/api.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 
 # pylint: disable=W0201
 
 
 import json
 import os
@@ skipping 64 matching lines @@
                            self.m.vars.checkout_root,
                            infra_step=True)
 
     # Initial cleanup.
     gclient_cfg = self.m.gclient.make_config(**cfg_kwargs)
     skia = gclient_cfg.solutions.add()
     skia.name = 'skia'
     skia.managed = False
     skia.url = 'https://skia.googlesource.com/skia.git'
     skia.revision = self.m.properties.get('revision') or 'origin/master'
-    self.update_repo(self.m.vars.checkout_root, skia)
-
-    # TODO(rmistry): Remove the below block after there is a solution for
-    #                crbug.com/616443
-    entries_file = self.m.vars.checkout_root.join('.gclient_entries')
-    if self.m.path.exists(entries_file):
-      self.m.file.remove('remove %s' % entries_file,
-                         entries_file,
-                         infra_step=True)  # pragma: no cover
+    # self.update_repo(self.m.vars.checkout_root, skia)
 
     if self.m.vars.need_chromium_checkout:
       chromium = gclient_cfg.solutions.add()
       chromium.name = 'src'
       chromium.managed = False
       chromium.url = 'https://chromium.googlesource.com/chromium/src.git'
       chromium.revision = 'origin/lkgr'
-      self.update_repo(self.m.vars.checkout_root, chromium)
+      # self.update_repo(self.m.vars.checkout_root, chromium)
 
     if self.m.vars.need_pdfium_checkout:
       pdfium = gclient_cfg.solutions.add()
       pdfium.name = 'pdfium'
       pdfium.managed = False
       pdfium.url = 'https://pdfium.googlesource.com/pdfium.git'
       pdfium.revision = 'origin/master'
-      self.update_repo(self.m.vars.checkout_root, pdfium)
+      # self.update_repo(self.m.vars.checkout_root, pdfium)
 
     # Run 'gclient sync'.
     gclient_cfg.got_revision_mapping['skia'] = 'got_revision'
     gclient_cfg.target_os.add('llvm')
     checkout_kwargs = {}
     checkout_kwargs['env'] = self.m.vars.default_env
 
     # api.gclient.revert() assumes things about the layout of the code, so it
     # fails for us. Run an appropriate revert sequence for trybots instead.
+    """
     gclient_file = self.m.vars.checkout_root.join('.gclient')
     if (self.m.tryserver.is_tryserver and
         self.m.path.exists(gclient_file)):  # pragma: no cover
       # These steps taken from:
       # https://chromium.googlesource.com/chromium/tools/build/+/
       #    81a696760ab7c25f6606c54fc781b90b8af9fdd2/scripts/slave/
       #    gclient_safe_revert.py
       if self.m.path.exists(entries_file):
         self.m.gclient('recurse', [
             'recurse', '-i', 'sh', '-c',
             'if [ -e .git ]; then git remote update; fi'])
       self.m.gclient(
           'revert',
           ['revert', '-v', '-v', '-v', '--nohooks', '--upstream'],
           cwd=self.m.vars.checkout_root)
+    """
 
-    update_step = self.m.gclient.checkout(gclient_config=gclient_cfg,
-                                          cwd=self.m.vars.checkout_root,
-                                          revert=False,
-                                          **checkout_kwargs)
+    # update_step = self.m.gclient.checkout(gclient_config=gclient_cfg,
+    #                                       cwd=self.m.vars.checkout_root,
+    #                                       revert=False,
+    #                                       **checkout_kwargs)
+
+    checkout_kwargs['cwd'] = self.m.vars.checkout_root
+    update_step = self.m.bot_update.ensure_checkout(
+        # Use the gclient_cfg we constructed above.
+        gclient_config=gclient_cfg,
+        # Always run bot_update. Seems to be turned on by other recipes as well.
+        force=True,
+        # Uncomment the below after recipe deps is rolled.
+        # Below param will not be needed after True is the default in bot_update.
+        # gerrit_rebase_patch_ref=True,
+        **checkout_kwargs)
 
     self.m.vars.got_revision = (
         update_step.presentation.properties['got_revision'])
-    self.m.tryserver.maybe_apply_issue()
+    # self.m.tryserver.maybe_apply_issue()
 
     if self.m.vars.need_chromium_checkout:
+      # rmistry: hooks??
       self.m.gclient.runhooks(cwd=self.m.vars.checkout_root,
                               env=self.m.vars.gclient_env)