Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2242213006: Fix an NPE as DownloadManager.query() could return a null cursor (Closed)

Created:
4 years, 4 months ago by qinmin
Modified:
4 years, 4 months ago
Reviewers:
gone
CC:
chromium-reviews, asanka
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix an NPE as DownloadManager.query() could return a null cursor Although not documented on SDK page, this is possible in DownloadManager source code. BUG=618458 Committed: https://crrev.com/757b19c57cfac1fdb034e9b79a80c2dcee9da260 Cr-Commit-Position: refs/heads/master@{#412696}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerDelegate.java View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
qinmin
PTAL
4 years, 4 months ago (2016-08-17 22:57:47 UTC) #3
gone
lgtm
4 years, 4 months ago (2016-08-17 23:00:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2242213006/20001
4 years, 4 months ago (2016-08-17 23:02:45 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 4 months ago (2016-08-17 23:51:55 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 00:01:31 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/757b19c57cfac1fdb034e9b79a80c2dcee9da260
Cr-Commit-Position: refs/heads/master@{#412696}

Powered by Google App Engine
This is Rietveld 408576698