src/interpreter/interpreter.cc - Issue 2242193002: [Interpreter] Avoid accessing Isolate from during bytecode generation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/interpreter/interpreter.cc

Issue 2242193002: [Interpreter] Avoid accessing Isolate from during bytecode generation. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@offheap_sourceposition

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/interpreter/interpreter.cc

diff --git a/src/interpreter/interpreter.cc b/src/interpreter/interpreter.cc

index 761199766eb9c5e3663ad435d55761c2775defe1..ba1c701c556977e0f5a4d8a95d1fc2d733ff5470 100644

--- a/src/interpreter/interpreter.cc

+++ b/src/interpreter/interpreter.cc

@@ -157,7 +157,7 @@ bool Interpreter::MakeBytecode(CompilationInfo* info) {

#endif // DEBUG

BytecodeGenerator generator(info);

- Handle<BytecodeArray> bytecodes = generator.MakeBytecode();

+ Handle<BytecodeArray> bytecodes = generator.MakeBytecode(info->isolate());

if (generator.HasStackOverflow()) return false;

« no previous file with comments | « src/interpreter/handler-table-builder.cc ('k') | test/cctest/interpreter/test-interpreter.cc » ('j') | no next file with comments »