Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Unified Diff: src/interpreter/constant-array-builder.h

Issue 2242193002: [Interpreter] Avoid accessing Isolate from during bytecode generation. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@offheap_sourceposition
Patch Set: Rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/interpreter/bytecode-register-optimizer.cc ('k') | src/interpreter/constant-array-builder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/interpreter/constant-array-builder.h
diff --git a/src/interpreter/constant-array-builder.h b/src/interpreter/constant-array-builder.h
index 136f999b259acdcfbad8ff36f82662b28f14e7b9..2018f256931c8e6cc18e95c5738f0d4bbc77eae7 100644
--- a/src/interpreter/constant-array-builder.h
+++ b/src/interpreter/constant-array-builder.h
@@ -32,10 +32,10 @@ class ConstantArrayBuilder final BASE_EMBEDDED {
static const size_t k32BitCapacity =
kMaxUInt32 - k16BitCapacity - k8BitCapacity + 1;
- ConstantArrayBuilder(Isolate* isolate, Zone* zone);
+ ConstantArrayBuilder(Zone* zone, Handle<Object> the_hole_value);
// Generate a fixed array of constants based on inserted objects.
- Handle<FixedArray> ToFixedArray();
+ Handle<FixedArray> ToFixedArray(Isolate* isolate);
// Returns the object in the constant pool array that at index
// |index|.
@@ -105,11 +105,13 @@ class ConstantArrayBuilder final BASE_EMBEDDED {
ConstantArraySlice* IndexToSlice(size_t index) const;
ConstantArraySlice* OperandSizeToSlice(OperandSize operand_size) const;
- Isolate* isolate_;
+ Handle<Object> the_hole_value() const { return the_hole_value_; }
+
ConstantArraySlice* idx_slice_[3];
ZoneMap<Address, index_t> constants_map_;
ZoneMap<Smi*, index_t> smi_map_;
ZoneVector<std::pair<Smi*, index_t>> smi_pairs_;
+ Handle<Object> the_hole_value_;
};
} // namespace interpreter
« no previous file with comments | « src/interpreter/bytecode-register-optimizer.cc ('k') | src/interpreter/constant-array-builder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698