src/interpreter/bytecode-register-optimizer.h - Issue 2242193002: [Interpreter] Avoid accessing Isolate from during bytecode generation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/interpreter/bytecode-register-optimizer.h

Issue 2242193002: [Interpreter] Avoid accessing Isolate from during bytecode generation. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@offheap_sourceposition

Patch Set: Address comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/interpreter/bytecode-register-optimizer.h

diff --git a/src/interpreter/bytecode-register-optimizer.h b/src/interpreter/bytecode-register-optimizer.h

index 4229610b1cd06b5e9afd1dbb6a46180de5a4d24b..fb087b527a84b1ed337aaaf532a6ca1e45b4e560 100644

--- a/src/interpreter/bytecode-register-optimizer.h

+++ b/src/interpreter/bytecode-register-optimizer.h

@@ -31,7 +31,7 @@ class BytecodeRegisterOptimizer final : public BytecodePipelineStage,

void BindLabel(BytecodeLabel* label) override;

void BindLabel(const BytecodeLabel& target, BytecodeLabel* label) override;

Handle<BytecodeArray> ToBytecodeArray(

- int fixed_register_count, int parameter_count,

+ Isolate* isolate, int fixed_register_count, int parameter_count,

Handle<FixedArray> handler_table) override;

private:

« src/interpreter/bytecode-generator.cc ('K') | « src/interpreter/bytecode-pipeline.h ('k') | src/interpreter/bytecode-register-optimizer.cc » ('j') | no next file with comments »