Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Side by Side Diff: src/interpreter/handler-table-builder.cc

Issue 2242193002: [Interpreter] Avoid accessing Isolate from during bytecode generation. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@offheap_sourceposition
Patch Set: Rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/interpreter/handler-table-builder.h ('k') | src/interpreter/interpreter.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 the V8 project authors. All rights reserved. 1 // Copyright 2016 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/interpreter/handler-table-builder.h" 5 #include "src/interpreter/handler-table-builder.h"
6 6
7 #include "src/factory.h" 7 #include "src/factory.h"
8 #include "src/interpreter/bytecode-register.h" 8 #include "src/interpreter/bytecode-register.h"
9 #include "src/isolate.h" 9 #include "src/isolate.h"
10 #include "src/objects-inl.h" 10 #include "src/objects-inl.h"
11 11
12 namespace v8 { 12 namespace v8 {
13 namespace internal { 13 namespace internal {
14 namespace interpreter { 14 namespace interpreter {
15 15
16 HandlerTableBuilder::HandlerTableBuilder(Isolate* isolate, Zone* zone) 16 HandlerTableBuilder::HandlerTableBuilder(Zone* zone) : entries_(zone) {}
17 : isolate_(isolate), entries_(zone) {}
18 17
19 Handle<HandlerTable> HandlerTableBuilder::ToHandlerTable() { 18 Handle<HandlerTable> HandlerTableBuilder::ToHandlerTable(Isolate* isolate) {
20 int handler_table_size = static_cast<int>(entries_.size()); 19 int handler_table_size = static_cast<int>(entries_.size());
21 Handle<HandlerTable> table = 20 Handle<HandlerTable> table =
22 Handle<HandlerTable>::cast(isolate_->factory()->NewFixedArray( 21 Handle<HandlerTable>::cast(isolate->factory()->NewFixedArray(
23 HandlerTable::LengthForRange(handler_table_size), TENURED)); 22 HandlerTable::LengthForRange(handler_table_size), TENURED));
24 for (int i = 0; i < handler_table_size; ++i) { 23 for (int i = 0; i < handler_table_size; ++i) {
25 Entry& entry = entries_[i]; 24 Entry& entry = entries_[i];
26 HandlerTable::CatchPrediction pred = entry.catch_prediction_; 25 HandlerTable::CatchPrediction pred = entry.catch_prediction_;
27 table->SetRangeStart(i, static_cast<int>(entry.offset_start)); 26 table->SetRangeStart(i, static_cast<int>(entry.offset_start));
28 table->SetRangeEnd(i, static_cast<int>(entry.offset_end)); 27 table->SetRangeEnd(i, static_cast<int>(entry.offset_end));
29 table->SetRangeHandler(i, static_cast<int>(entry.offset_target), pred); 28 table->SetRangeHandler(i, static_cast<int>(entry.offset_target), pred);
30 table->SetRangeData(i, entry.context.index()); 29 table->SetRangeData(i, entry.context.index());
31 } 30 }
32 return table; 31 return table;
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 } 63 }
65 64
66 65
67 void HandlerTableBuilder::SetContextRegister(int handler_id, Register reg) { 66 void HandlerTableBuilder::SetContextRegister(int handler_id, Register reg) {
68 entries_[handler_id].context = reg; 67 entries_[handler_id].context = reg;
69 } 68 }
70 69
71 } // namespace interpreter 70 } // namespace interpreter
72 } // namespace internal 71 } // namespace internal
73 } // namespace v8 72 } // namespace v8
OLDNEW
« no previous file with comments | « src/interpreter/handler-table-builder.h ('k') | src/interpreter/interpreter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698