[Interpreter] Avoid accessing Isolate from during bytecode generation.

src/interpreter/bytecode-generator.h

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_INTERPRETER_BYTECODE_GENERATOR_H_
 #define V8_INTERPRETER_BYTECODE_GENERATOR_H_
 
 #include "src/ast/ast.h"
 #include "src/interpreter/bytecode-array-builder.h"
 #include "src/interpreter/bytecode-label.h"
 #include "src/interpreter/bytecode-register.h"
 #include "src/interpreter/bytecodes.h"
 
 namespace v8 {
 namespace internal {
 
 class CompilationInfo;
 
 namespace interpreter {
 
 class LoopBuilder;
 
 class BytecodeGenerator final : public AstVisitor<BytecodeGenerator> {
  public:
   explicit BytecodeGenerator(CompilationInfo* info);
 
-  Handle<BytecodeArray> MakeBytecode();
+  Handle<BytecodeArray> MakeBytecode(Isolate* isolate);
 
 #define DECLARE_VISIT(type) void Visit##type(type* node);
   AST_NODE_LIST(DECLARE_VISIT)
 #undef DECLARE_VISIT
 
   // Visiting function for declarations list and statements are overridden.
   void VisitDeclarations(ZoneList<Declaration*>* declarations);
   void VisitStatements(ZoneList<Statement*>* statments);
 
  private:
   class AccumulatorResultScope;
   class ContextScope;
   class ControlScope;
   class ControlScopeForBreakable;
   class ControlScopeForIteration;
   class ControlScopeForTopLevel;
   class ControlScopeForTryCatch;
   class ControlScopeForTryFinally;
   class ExpressionResultScope;
   class EffectResultScope;
   class GlobalDeclarationsBuilder;
   class RegisterResultScope;
   class RegisterAllocationScope;
   class TestResultScope;
 
   enum class TestFallthrough { kThen, kElse, kNone };
 
   void GenerateBytecode();
   void GenerateBytecodeBody();
-  void FinalizeBytecode();
+  void FinalizeBytecode(Isolate* isolate);
 
   DEFINE_AST_VISITOR_SUBCLASS_MEMBERS();
 
   // Dispatched from VisitBinaryOperation.
   void VisitArithmeticExpression(BinaryOperation* binop);
   void VisitCommaExpression(BinaryOperation* binop);
   void VisitLogicalOrExpression(BinaryOperation* binop);
   void VisitLogicalAndExpression(BinaryOperation* binop);
 
   // Dispatched from VisitUnaryOperation.
@@ skipping 102 matching lines @@
 
   // Methods for tracking and remapping register.
   void RecordStoreToRegister(Register reg);
   Register LoadFromAliasedRegister(Register reg);
 
   // Initialize an array of temporary registers with consecutive registers.
   template <size_t N>
   void InitializeWithConsecutiveRegisters(Register (&registers)[N]);
 
   inline BytecodeArrayBuilder* builder() const { return builder_; }
-  inline Isolate* isolate() const { return isolate_; }
   inline Zone* zone() const { return zone_; }
   inline DeclarationScope* scope() const { return scope_; }
   inline CompilationInfo* info() const { return info_; }
 
   inline ControlScope* execution_control() const { return execution_control_; }
   inline void set_execution_control(ControlScope* scope) {
     execution_control_ = scope;
   }
   inline ContextScope* execution_context() const { return execution_context_; }
   inline void set_execution_context(ContextScope* context) {
     execution_context_ = context;
   }
   inline void set_execution_result(ExpressionResultScope* execution_result) {
     execution_result_ = execution_result;
   }
   ExpressionResultScope* execution_result() const { return execution_result_; }
   inline void set_register_allocator(
       RegisterAllocationScope* register_allocator) {
     register_allocator_ = register_allocator;
   }
   RegisterAllocationScope* register_allocator() const {
     return register_allocator_;
   }
 
   GlobalDeclarationsBuilder* globals_builder() { return globals_builder_; }
   inline LanguageMode language_mode() const;
   int feedback_index(FeedbackVectorSlot slot) const;
 
-  Isolate* isolate_;
+  Handle<Name> home_object_symbol() const { return home_object_symbol_; }
+  Handle<Name> prototype_string() const { return prototype_string_; }
+
   Zone* zone_;
   BytecodeArrayBuilder* builder_;
   CompilationInfo* info_;
   DeclarationScope* scope_;
+  bool isolate_access_allowed_;

[Michael Starzinger, 2016/08/16 12:26:50]

nit: Field should no longer be required. Lets drop it.

[rmcilroy, 2016/08/16 14:22:30]

Done.

+
   GlobalDeclarationsBuilder* globals_builder_;
   ZoneVector<GlobalDeclarationsBuilder*> global_declarations_;
   ZoneVector<std::pair<FunctionLiteral*, size_t>> function_literals_;
   ZoneVector<std::pair<NativeFunctionLiteral*, size_t>>
       native_function_literals_;
+
   ControlScope* execution_control_;
   ContextScope* execution_context_;
   ExpressionResultScope* execution_result_;
   RegisterAllocationScope* register_allocator_;
+
   ZoneVector<BytecodeLabel> generator_resume_points_;
   Register generator_state_;
   int loop_depth_;
+
+  Handle<Name> home_object_symbol_;
+  Handle<Name> prototype_string_;
 };
 
 }  // namespace interpreter
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_INTERPRETER_BYTECODE_GENERATOR_H_