Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 2242173005: End the drag and drop operation properly. (Closed)

Created:
4 years, 4 months ago by hush (inactive)
Modified:
4 years, 4 months ago
Reviewers:
no sievers
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

End the drag and drop operation properly. Blink::WebViewImpl will ignore the inputs when it thinks it's doing drag and drop. As a result, we need to clear the states properly during early outs in content/ layer. BUG=638424 Committed: https://crrev.com/5996d6944ebdca3d0df4c2561f75e1f7b949edf9 Cr-Commit-Position: refs/heads/master@{#413605}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M content/browser/renderer_host/render_view_host_impl.cc View 1 chunk +4 lines, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_android.cc View 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
hush (inactive)
Hello Daniel, could you take a look? Thanks!
4 years, 4 months ago (2016-08-17 00:16:19 UTC) #2
no sievers
lgtm. also see the comment in render_view_host_delegate_view.h: // The user started dragging content of the ...
4 years, 4 months ago (2016-08-17 18:18:38 UTC) #3
hush (inactive)
I'm just gonna submit this CL as it is. There are logic in other platforms ...
4 years, 4 months ago (2016-08-19 21:59:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2242173005/1
4 years, 4 months ago (2016-08-19 22:00:34 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/126210)
4 years, 4 months ago (2016-08-20 01:27:06 UTC) #8
no sievers
On 2016/08/19 21:59:31, hush wrote: > I'm just gonna submit this CL as it is. ...
4 years, 4 months ago (2016-08-22 22:08:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2242173005/1
4 years, 4 months ago (2016-08-22 22:25:01 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-23 00:34:09 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-23 00:35:28 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5996d6944ebdca3d0df4c2561f75e1f7b949edf9
Cr-Commit-Position: refs/heads/master@{#413605}

Powered by Google App Engine
This is Rietveld 408576698