Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2242023002: DevTools: Timeline warning colors should scale with severity.

Created:
4 years, 4 months ago by paulirish
Modified:
4 years, 3 months ago
Reviewers:
caseq, alph
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Timeline warning colors should scale with severity. BUG=637573

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -11 lines) Patch
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineEventOverview.js View 3 chunks +13 lines, -10 lines 1 comment Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js View 1 chunk +7 lines, -1 line 1 comment Download

Messages

Total messages: 5 (2 generated)
paulirish
wdyt? screenshot in bug
4 years, 4 months ago (2016-08-13 23:54:32 UTC) #2
caseq
https://codereview.chromium.org/2242023002/diff/1/third_party/WebKit/Source/devtools/front_end/timeline/TimelineEventOverview.js File third_party/WebKit/Source/devtools/front_end/timeline/TimelineEventOverview.js (right): https://codereview.chromium.org/2242023002/diff/1/third_party/WebKit/Source/devtools/front_end/timeline/TimelineEventOverview.js#newcode418 third_party/WebKit/Source/devtools/front_end/timeline/TimelineEventOverview.js:418: var overage = duration - 16; should we do ...
4 years, 4 months ago (2016-08-16 18:37:17 UTC) #4
alph
4 years, 3 months ago (2016-08-31 19:38:43 UTC) #5 
Overview part sgtm. Not sure about the main flamechart.

https://codereview.chromium.org/2242023002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js
(right):

https://codereview.chromium.org/2242023002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js:748:
var intensity = Number.constrain(frame.duration / (30 + frame.duration), 0,
1).toFixed(3);
You have a different formula here. Is it intended?

Powered by Google App Engine
This is Rietveld 408576698