Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 22420004: Check for empty handle in JSON stringifier (Closed)

Created:
7 years, 4 months ago by Jakob Kummerow
Modified:
7 years, 4 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Check for empty handle in JSON stringifier R=yangguo@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=16106

Patch Set 1 #

Patch Set 2 : faster test case (doesn't depend on stack overflow) #

Patch Set 3 : renamed test case #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -11 lines) Patch
M src/json-stringifier.h View 1 chunk +1 line, -0 lines 0 comments Download
A + test/mjsunit/regress/json-stringifier-emptyhandle.js View 1 2 1 chunk +12 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jakob Kummerow
PTAL.
7 years, 4 months ago (2013-08-06 15:02:29 UTC) #1
Yang
On 2013/08/06 15:02:29, Jakob wrote: > PTAL. LGTM.
7 years, 4 months ago (2013-08-07 16:11:14 UTC) #2
Jakob Kummerow
7 years, 4 months ago (2013-08-07 16:34:19 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r16106 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698