third_party/WebKit/LayoutTests/css3/motion-path/path-establishes-stacking-context.html - Issue 2241993002: CSS Motion Path: New names for properties

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/css3/motion-path/path-establishes-stacking-context.html

Issue 2241993002: CSS Motion Path: New names for properties (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/css3/motion-path/offset-rotation.html ('k') | third_party/WebKit/LayoutTests/css3/motion-path/zero-length.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <style>	4 <style>

5	5

6 div {	6 div {

7 width: 800px;	7 width: 800px;

8 }	8 }

9	9

10 span {	10 span {

(...skipping 18 matching lines...) Expand all Loading...
29 background: green;	29 background: green;

30 }	30 }

31	31

32 #span3 {	32 #span3 {

33 left: 150px;	33 left: 150px;

34 top: 150px;	34 top: 150px;

35 background: blue;	35 background: blue;

36 }	36 }

37	37

38 #div1 {	38 #div1 {

39 motion-path: path('M400,0');	39 offset-path: path('M400,0');
	suzyh_UTC10 (ex-contributor) 2016/09/19 03:32:30 If adding offset-path to hasPropertyThatCreatesSta If adding offset-path to hasPropertyThatCreatesStackingContext was a bug fix that changed behaviour, why was this test (which I expect, based on the name, is related) unaffected? Does this test actually test what it's supposed to test? Eric Willigers 2016/09/19 04:46:14 hasPropertyThatCreatesStackingContext is about wil Show quoted text On 2016/09/19 03:32:30, suzyh wrote: > If adding offset-path to hasPropertyThatCreatesStackingContext was a bug fix > that changed behaviour, why was this test (which I expect, based on the name, is > related) unaffected? Does this test actually test what it's supposed to test? hasPropertyThatCreatesStackingContext is about will-change. https://dev.opera.com/articles/css-will-change-property/ https://developer.mozilla.org/en/docs/Web/CSS/will-change https://drafts.csswg.org/css-will-change/ If any non-initial value of a property would create a stacking context on the element, specifying that property in will-change must create a stacking context on the element. The idea is that div1 { will-change: offset-path; offset-path: none; } should create a stacking context. As for this test's effectiveness, I've included the question in crbug.com/648113 In this CL, we are simply migrating the existing test to the new name.
40 }	40 }

41	41

42 #div2 {	42 #div2 {

43 motion-path: none;	43 offset-path: none;

44 }	44 }

45	45

46 </style>	46 </style>

47 </head>	47 </head>

48 <body>	48 <body>

49	49

50 <div id="div1">	50 <div id="div1">

51 <span id="span1">First</span>	51 <span id="span1">First</span>

52 </div>	52 </div>

53 <div id="div2">	53 <div id="div2">

54 <span id="span2">Second</span>	54 <span id="span2">Second</span>

55 </div>	55 </div>

56 <div id="div3">	56 <div id="div3">

57 <span id="span3">Third</span>	57 <span id="span3">Third</span>

58 </div>	58 </div>

59	59

60 </body>	60 </body>

61 </html>	61 </html>

OLD	NEW