Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Issue 2241943002: [Material][Mac] Fixed EV chip's dark theme colors (Closed)

Created:
4 years, 4 months ago by spqchan
Modified:
4 years, 4 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Material][Mac] Fixed EV chip's dark theme colors Use hasDarkTheme instead of inIncognitoModeWithSystemTheme so that the chip gets the correct value. BUG=629995 Committed: https://crrev.com/f54c0238952086f5cf5c3dce0f5bdbf88a6d4d72 Cr-Commit-Position: refs/heads/master@{#411994}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/cocoa/location_bar/bubble_decoration.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
spqchan
PTAL
4 years, 4 months ago (2016-08-15 16:39:24 UTC) #3
Avi (use Gerrit)
lgtm
4 years, 4 months ago (2016-08-15 17:41:32 UTC) #4
spqchan
On 2016/08/15 17:41:32, Avi wrote: > lgtm thanks!
4 years, 4 months ago (2016-08-15 17:42:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2241943002/1
4 years, 4 months ago (2016-08-15 17:43:26 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-15 18:33:52 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-15 18:37:30 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f54c0238952086f5cf5c3dce0f5bdbf88a6d4d72
Cr-Commit-Position: refs/heads/master@{#411994}

Powered by Google App Engine
This is Rietveld 408576698