Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2241863004: Enable support for Rice encoding (Closed)

Created:
4 years, 4 months ago by vakh (use Gerrit instead)
Modified:
4 years, 4 months ago
Reviewers:
Nathan Parker
CC:
chromium-reviews, woz, Scott Hess - ex-Googler, francois_mozilla.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@01_checksum_errors
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable support for Rice encoding BUG=543161, 624567 Committed: https://crrev.com/f55c5b229c13a6266c16b2234af973c569303de1 Cr-Commit-Position: refs/heads/master@{#413066}

Patch Set 1 #

Patch Set 2 : Enable Chrome to request Rice encoding #

Total comments: 4

Patch Set 3 : Remove TODO. Update test to expect RICE as supported compression. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M components/safe_browsing_db/v4_update_protocol_manager.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M components/safe_browsing_db/v4_update_protocol_manager_unittest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (8 generated)
vakh (use Gerrit instead)
Enable Chrome to request Rice encoding
4 years, 4 months ago (2016-08-17 22:31:38 UTC) #1
vakh (use Gerrit instead)
4 years, 4 months ago (2016-08-17 22:32:57 UTC) #3
Nathan Parker
lgtm https://codereview.chromium.org/2241863004/diff/20001/components/safe_browsing_db/v4_update_protocol_manager.cc File components/safe_browsing_db/v4_update_protocol_manager.cc (right): https://codereview.chromium.org/2241863004/diff/20001/components/safe_browsing_db/v4_update_protocol_manager.cc#newcode215 components/safe_browsing_db/v4_update_protocol_manager.cc:215: // TODO(vakh): Accept other compression formats also. remove ...
4 years, 4 months ago (2016-08-19 00:18:23 UTC) #4
vakh (use Gerrit instead)
Remove TODO. Update test to expect RICE as supported compression.
4 years, 4 months ago (2016-08-19 00:45:05 UTC) #5
vakh (use Gerrit instead)
https://codereview.chromium.org/2241863004/diff/20001/components/safe_browsing_db/v4_update_protocol_manager.cc File components/safe_browsing_db/v4_update_protocol_manager.cc (right): https://codereview.chromium.org/2241863004/diff/20001/components/safe_browsing_db/v4_update_protocol_manager.cc#newcode215 components/safe_browsing_db/v4_update_protocol_manager.cc:215: // TODO(vakh): Accept other compression formats also. On 2016/08/19 ...
4 years, 4 months ago (2016-08-19 00:46:35 UTC) #8
vakh (use Gerrit instead)
4 years, 4 months ago (2016-08-19 00:47:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2241863004/40001
4 years, 4 months ago (2016-08-19 06:12:13 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-19 06:15:50 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 06:19:30 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f55c5b229c13a6266c16b2234af973c569303de1
Cr-Commit-Position: refs/heads/master@{#413066}

Powered by Google App Engine
This is Rietveld 408576698