Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1689)

Unified Diff: xfa/fxfa/parser/xfa_locale.h

Issue 2241863002: Clean up XFA locale and locale manager (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: const funcs Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: xfa/fxfa/parser/xfa_locale.h
diff --git a/xfa/fxfa/parser/xfa_locale.h b/xfa/fxfa/parser/xfa_locale.h
index 0463a9f9e916adbb1936a00e0dc969086a2c77e7..75104b456cccb84bf42cee76044abc970ff38267 100644
--- a/xfa/fxfa/parser/xfa_locale.h
+++ b/xfa/fxfa/parser/xfa_locale.h
@@ -15,10 +15,10 @@
class CXFA_XMLLocale : public IFX_Locale {
public:
explicit CXFA_XMLLocale(std::unique_ptr<CXML_Element> pLocaleData);
+ ~CXFA_XMLLocale() override;
// IFX_Locale
- void Release() override;
- CFX_WideString GetName() override;
+ CFX_WideString GetName() const override;
void GetNumbericSymbol(FX_LOCALENUMSYMBOL eType,
CFX_WideString& wsNumSymbol) const override;
@@ -42,8 +42,6 @@ class CXFA_XMLLocale : public IFX_Locale {
CFX_WideString& wsPattern) const override;
protected:
- ~CXFA_XMLLocale() override;
-
void GetPattern(CXML_Element* pElement,
const CFX_ByteStringC& bsTag,
const CFX_WideStringC& wsName,
@@ -59,10 +57,10 @@ class CXFA_XMLLocale : public IFX_Locale {
class CXFA_NodeLocale : public IFX_Locale {
public:
CXFA_NodeLocale(CXFA_Node* pLocale);
+ ~CXFA_NodeLocale() override;
// IFX_Locale
- void Release() override;
- CFX_WideString GetName() override;
+ CFX_WideString GetName() const override;
void GetNumbericSymbol(FX_LOCALENUMSYMBOL eType,
CFX_WideString& wsNumSymbol) const override;
@@ -86,8 +84,6 @@ class CXFA_NodeLocale : public IFX_Locale {
CFX_WideString& wsPattern) const override;
protected:
- ~CXFA_NodeLocale() override;
-
CXFA_Node* GetNodeByName(CXFA_Node* pParent,
const CFX_WideStringC& wsName) const;
CFX_WideString GetSymbol(XFA_Element eElement,

Powered by Google App Engine
This is Rietveld 408576698