Clean up XFA locale and locale manager

xfa/fgas/localization/fgas_locale.h

Index: xfa/fgas/localization/fgas_locale.h
diff --git a/xfa/fgas/localization/fgas_locale.h b/xfa/fgas/localization/fgas_locale.h
index 3401d6ca5a33766547276058b5cb20c26e4e01db..32de9d9b05aab5050908f59efdcacf2eee71cf00 100644
--- a/xfa/fgas/localization/fgas_locale.h
+++ b/xfa/fgas/localization/fgas_locale.h
@@ -54,12 +54,9 @@ enum FX_DATETIMETYPE {
 
 class IFX_Locale {
  public:
-
   virtual ~IFX_Locale() {}
-  virtual void Release() = 0;
-
-  virtual CFX_WideString GetName() = 0;
 
+  virtual CFX_WideString GetName() const = 0;
   virtual void GetNumbericSymbol(FX_LOCALENUMSYMBOL eType,
                                  CFX_WideString& wsNumSymbol) const = 0;
   virtual void GetDateTimeSymbols(CFX_WideString& wsDtSymbol) const = 0;
@@ -85,10 +82,10 @@ class IFX_Locale {
 class IFX_LocaleMgr {
  public:
   virtual ~IFX_LocaleMgr() {}
-  virtual void Release() = 0;
-  virtual uint16_t GetDefLocaleID() = 0;
+
+  virtual uint16_t GetDefLocaleID() const = 0;
   virtual IFX_Locale* GetDefLocale() = 0;
-  virtual IFX_Locale* GetLocale(uint16_t lcid) = 0;
+  virtual std::unique_ptr<IFX_Locale> GetLocale(uint16_t lcid) = 0;
   virtual IFX_Locale* GetLocaleByName(const CFX_WideString& wsLocaleName) = 0;

[Tom Sepez, 2016/08/12 23:21:37]

Curious why this one doesn't return unqiue_ptr, too.  Is it a shared locale?

[Wei Li, 2016/08/15 18:37:29]

All locales are owned by LocalMgr, GetLocale() should be just an internal helper
function. Changed to make this clearer.

 };