Clean up XFA locale and locale manager

xfa/fgas/localization/fgas_locale.h

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #ifndef XFA_FGAS_LOCALIZATION_FGAS_LOCALE_H_
 #define XFA_FGAS_LOCALIZATION_FGAS_LOCALE_H_
 
 #include "core/fxcrt/include/fx_xml.h"
@@ skipping 36 matching lines @@
 enum FX_DATETIMETYPE {
   FX_DATETIMETYPE_Unknown,
   FX_DATETIMETYPE_Date,
   FX_DATETIMETYPE_Time,
   FX_DATETIMETYPE_DateTime,
   FX_DATETIMETYPE_TimeDate,
 };
 
 class IFX_Locale {
  public:
+  virtual ~IFX_Locale() {}
 
-  virtual ~IFX_Locale() {}
-  virtual void Release() = 0;
-
-  virtual CFX_WideString GetName() = 0;
-
+  virtual CFX_WideString GetName() const = 0;
   virtual void GetNumbericSymbol(FX_LOCALENUMSYMBOL eType,
                                  CFX_WideString& wsNumSymbol) const = 0;
   virtual void GetDateTimeSymbols(CFX_WideString& wsDtSymbol) const = 0;
   virtual void GetMonthName(int32_t nMonth,
                             CFX_WideString& wsMonthName,
                             FX_BOOL bAbbr = TRUE) const = 0;
   virtual void GetDayName(int32_t nWeek,
                           CFX_WideString& wsDayName,
                           FX_BOOL bAbbr = TRUE) const = 0;
   virtual void GetMeridiemName(CFX_WideString& wsMeridiemName,
                                FX_BOOL bAM = TRUE) const = 0;
   virtual void GetTimeZone(FX_TIMEZONE& tz) const = 0;
   virtual void GetEraName(CFX_WideString& wsEraName,
                           FX_BOOL bAD = TRUE) const = 0;
   virtual void GetDatePattern(FX_LOCALEDATETIMESUBCATEGORY eType,
                               CFX_WideString& wsPattern) const = 0;
   virtual void GetTimePattern(FX_LOCALEDATETIMESUBCATEGORY eType,
                               CFX_WideString& wsPattern) const = 0;
   virtual void GetNumPattern(FX_LOCALENUMSUBCATEGORY eType,
                              CFX_WideString& wsPattern) const = 0;
 };
 
 class IFX_LocaleMgr {
  public:
   virtual ~IFX_LocaleMgr() {}
-  virtual void Release() = 0;
-  virtual uint16_t GetDefLocaleID() = 0;
+
+  virtual uint16_t GetDefLocaleID() const = 0;
   virtual IFX_Locale* GetDefLocale() = 0;
-  virtual IFX_Locale* GetLocale(uint16_t lcid) = 0;
   virtual IFX_Locale* GetLocaleByName(const CFX_WideString& wsLocaleName) = 0;
+
+ protected:
+  virtual std::unique_ptr<IFX_Locale> GetLocale(uint16_t lcid) = 0;
 };
 
 FX_BOOL FX_DateFromCanonical(const CFX_WideString& wsDate,
                              CFX_Unitime& datetime);
 FX_BOOL FX_TimeFromCanonical(const CFX_WideStringC& wsTime,
                              CFX_Unitime& datetime,
                              IFX_Locale* pLocale);
 class CFX_Decimal {
  public:
   CFX_Decimal();
@@ skipping 39 matching lines @@
   CFX_Decimal Multiply(const CFX_Decimal& val) const;
   CFX_Decimal Divide(const CFX_Decimal& val) const;
   CFX_Decimal Modulus(const CFX_Decimal& val) const;
   uint32_t m_uFlags;
   uint32_t m_uHi;
   uint32_t m_uLo;
   uint32_t m_uMid;
 };
 
 #endif  // XFA_FGAS_LOCALIZATION_FGAS_LOCALE_H_