Clean up XFA locale and locale manager

Clean up XFA locale and locale manager

Return unique_ptr for GetLocale(), directly use destructors
instead of Release() functions, use vectors to manage arrays.

Committed: https://pdfium.googlesource.com/pdfium/+/8e557bd9e7c09f9ce75fbea42f826b74d5cdc54b

[Wei Li, 2016-08-12 19:31:00]

Description was changed from

==========
Clean up locale and locale manager

Return unique_ptr for GetLocale, remove unnecessary Release()
functions, use vector to manage arrays.
==========

to

==========
Clean up XFA locale and locale manager

Return unique_ptr for GetLocale(), directly use destructors
instead of Release() 
functions, use vectors to manage arrays.
==========

[Wei Li, 2016-08-12 19:31:17]

Description was changed from

==========
Clean up XFA locale and locale manager

Return unique_ptr for GetLocale(), directly use destructors
instead of Release() 
functions, use vectors to manage arrays.
==========

to

==========
Clean up XFA locale and locale manager

Return unique_ptr for GetLocale(), directly use destructors
instead of Release() functions, use vectors to manage arrays.
==========

[Wei Li, 2016-08-12 19:31:27]

The CQ bit was checked by weili@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 19:31:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 19:50:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 19:50:43]

Dry run: This issue passed the CQ dry run.

[Wei Li, 2016-08-12 20:15:03]

weili@chromium.org changed reviewers:
+ dsinclair@chromium.org, tsepez@chromium.org

[Wei Li, 2016-08-12 20:15:04]

pls review, thanks

[Tom Sepez, 2016-08-12 23:21:37]

https://codereview.chromium.org/2241863002/diff/20001/xfa/fgas/localization/f...
File xfa/fgas/localization/fgas_locale.h (right):

https://codereview.chromium.org/2241863002/diff/20001/xfa/fgas/localization/f...
xfa/fgas/localization/fgas_locale.h:89: virtual IFX_Locale*
GetLocaleByName(const CFX_WideString& wsLocaleName) = 0;
Curious why this one doesn't return unqiue_ptr, too.  Is it a shared locale?

[Wei Li, 2016-08-15 18:34:42]

Patchset #4 (id:60001) has been deleted

[Wei Li, 2016-08-15 18:37:29]

ptal, thanks

https://codereview.chromium.org/2241863002/diff/20001/xfa/fgas/localization/f...
File xfa/fgas/localization/fgas_locale.h (right):

https://codereview.chromium.org/2241863002/diff/20001/xfa/fgas/localization/f...
xfa/fgas/localization/fgas_locale.h:89: virtual IFX_Locale*
GetLocaleByName(const CFX_WideString& wsLocaleName) = 0;
On 2016/08/12 23:21:37, Tom Sepez wrote:
> Curious why this one doesn't return unqiue_ptr, too.  Is it a shared locale?

All locales are owned by LocalMgr, GetLocale() should be just an internal helper
function. Changed to make this clearer.

[Tom Sepez, 2016-08-15 18:40:14]

lgtm

[Wei Li, 2016-08-15 18:54:13]

The CQ bit was checked by weili@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-15 18:54:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 19:14:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 19:14:44]

Dry run: This issue passed the CQ dry run.

[Wei Li, 2016-08-15 19:25:11]

The CQ bit was checked by weili@chromium.org

[Wei Li, 2016-08-15 19:25:11]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2241863002/#ps80001
(title: "small fix")

[commit-bot: I haz the power, 2016-08-15 19:25:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 19:25:32]

Description was changed from

==========
Clean up XFA locale and locale manager

Return unique_ptr for GetLocale(), directly use destructors
instead of Release() functions, use vectors to manage arrays.
==========

to

==========
Clean up XFA locale and locale manager

Return unique_ptr for GetLocale(), directly use destructors
instead of Release() functions, use vectors to manage arrays.

Committed:
https://pdfium.googlesource.com/pdfium/+/8e557bd9e7c09f9ce75fbea42f826b74d5cd...
==========

[commit-bot: I haz the power, 2016-08-15 19:25:33]

Committed patchset #4 (id:80001) as
https://pdfium.googlesource.com/pdfium/+/8e557bd9e7c09f9ce75fbea42f826b74d5cd...