Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 2241863002: Clean up XFA locale and locale manager (Closed)

Created:
4 years, 4 months ago by Wei Li
Modified:
4 years, 4 months ago
Reviewers:
Tom Sepez, dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Clean up XFA locale and locale manager Return unique_ptr for GetLocale(), directly use destructors instead of Release() functions, use vectors to manage arrays. Committed: https://pdfium.googlesource.com/pdfium/+/8e557bd9e7c09f9ce75fbea42f826b74d5cdc54b

Patch Set 1 #

Patch Set 2 : const funcs #

Total comments: 2

Patch Set 3 : address comment #

Patch Set 4 : small fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -108 lines) Patch
M xfa/fgas/localization/fgas_locale.h View 1 2 2 chunks +6 lines, -7 lines 0 comments Download
M xfa/fxfa/parser/xfa_locale.h View 1 4 chunks +4 lines, -8 lines 0 comments Download
M xfa/fxfa/parser/xfa_locale.cpp View 1 2 chunks +2 lines, -10 lines 0 comments Download
M xfa/fxfa/parser/xfa_localemgr.h View 1 2 3 2 chunks +9 lines, -6 lines 0 comments Download
M xfa/fxfa/parser/xfa_localemgr.cpp View 1 6 chunks +57 lines, -77 lines 0 comments Download

Messages

Total messages: 21 (15 generated)
Wei Li
pls review, thanks
4 years, 4 months ago (2016-08-12 20:15:04 UTC) #8
Tom Sepez
https://codereview.chromium.org/2241863002/diff/20001/xfa/fgas/localization/fgas_locale.h File xfa/fgas/localization/fgas_locale.h (right): https://codereview.chromium.org/2241863002/diff/20001/xfa/fgas/localization/fgas_locale.h#newcode89 xfa/fgas/localization/fgas_locale.h:89: virtual IFX_Locale* GetLocaleByName(const CFX_WideString& wsLocaleName) = 0; Curious why ...
4 years, 4 months ago (2016-08-12 23:21:37 UTC) #9
Wei Li
ptal, thanks https://codereview.chromium.org/2241863002/diff/20001/xfa/fgas/localization/fgas_locale.h File xfa/fgas/localization/fgas_locale.h (right): https://codereview.chromium.org/2241863002/diff/20001/xfa/fgas/localization/fgas_locale.h#newcode89 xfa/fgas/localization/fgas_locale.h:89: virtual IFX_Locale* GetLocaleByName(const CFX_WideString& wsLocaleName) = 0; ...
4 years, 4 months ago (2016-08-15 18:37:29 UTC) #11
Tom Sepez
lgtm
4 years, 4 months ago (2016-08-15 18:40:14 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2241863002/80001
4 years, 4 months ago (2016-08-15 19:25:14 UTC) #19
commit-bot: I haz the power
4 years, 4 months ago (2016-08-15 19:25:33 UTC) #21
Message was sent while issue was closed.
Committed patchset #4 (id:80001) as
https://pdfium.googlesource.com/pdfium/+/8e557bd9e7c09f9ce75fbea42f826b74d5cd...

Powered by Google App Engine
This is Rietveld 408576698