Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 2241833003: Revert of Fail builds when lint warnings are generated. (Closed)

Created:
4 years, 4 months ago by agrieve
Modified:
4 years, 4 months ago
Reviewers:
caseq, estevenson
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fail builds when lint warnings are generated. (patchset #1 id:1 of https://codereview.chromium.org/2241973002/ ) Reason for revert: Broke clank tot roller: https://uberchromegw.corp.google.com/i/internal.client.clank_tot/builders/clang-clankium-tot-builder/builds/32680/steps/compile/logs/stdio Original issue's description: > Reland #2 of Fail builds when lint warnings are generated > > Previous: https://codereview.chromium.org/2236313004/ > > Reason for revert: > If this fails again, please revert changes that introduce > new warnings rather than this patch. > > TBR=estevenson@chromium.org,caseq@chromium.org > BUG=607761 > > Committed: https://crrev.com/f8bde5d301337c0994a9d71fc31ed71b36a26e47 > Cr-Commit-Position: refs/heads/master@{#411864} TBR=estevenson@chromium.org,caseq@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=607761 Committed: https://crrev.com/1155b192671fe54bd88883f511dc98d95a9b5489 Cr-Commit-Position: refs/heads/master@{#411871}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -197 lines) Patch
M build/android/gyp/lint.py View 1 chunk +1 line, -4 lines 0 comments Download
M build/android/lint/suppressions.xml View 1 chunk +59 lines, -192 lines 0 comments Download
M build/config/android/internal_rules.gni View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
agrieve
Created Revert of Fail builds when lint warnings are generated.
4 years, 4 months ago (2016-08-13 03:44:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2241833003/1
4 years, 4 months ago (2016-08-13 03:44:58 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-13 03:47:28 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-13 03:49:34 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1155b192671fe54bd88883f511dc98d95a9b5489
Cr-Commit-Position: refs/heads/master@{#411871}

Powered by Google App Engine
This is Rietveld 408576698