mac: Remove dead NotificationUIManagerMac.

mac: Remove dead NotificationUIManagerMac.

BUG=120677
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261516

[Robert Sesek, 2014-04-03 17:07:03]

I'm not sure this will work as is. C.f.
https://codereview.chromium.org/23361031/

[Nico, 2014-04-03 17:08:39]

Bleh, missed the NotificationUIManager::Create in the .mm file, sorry.


On Thu, Apr 3, 2014 at 10:07 AM, <rsesek@chromium.org> wrote:

> I'm not sure this will work as is. C.f.
> https://codereview.chromium.org/23361031/
>
> https://codereview.chromium.org/224183002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Robert Sesek, 2014-04-03 17:09:23]

On 2014/04/03 17:08:39, Nico wrote:
> Bleh, missed the NotificationUIManager::Create in the .mm file, sorry.
> 
> 
> On Thu, Apr 3, 2014 at 10:07 AM, <mailto:rsesek@chromium.org> wrote:
> 
> > I'm not sure this will work as is. C.f.
> > https://codereview.chromium.org/23361031/
> >
> > https://codereview.chromium.org/224183002/
> >
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

I've been waiting for the gtk code to be deleted, and then I was going to pick
that CL back up.

[Nico, 2014-04-03 17:11:31]

…but looking for callers of NotificationUIManager::Create, it looks
like chrome/browser/extensions/api/notifications/notifications_api.cc is
eventually backed by the code here (?)


On Thu, Apr 3, 2014 at 10:09 AM, <rsesek@chromium.org> wrote:

> On 2014/04/03 17:08:39, Nico wrote:
>
>> Bleh, missed the NotificationUIManager::Create in the .mm file, sorry.
>>
>
>
>  On Thu, Apr 3, 2014 at 10:07 AM, <mailto:rsesek@chromium.org> wrote:
>>
>
>  > I'm not sure this will work as is. C.f.
>> > https://codereview.chromium.org/23361031/
>> >
>> > https://codereview.chromium.org/224183002/
>> >
>>
>
>  To unsubscribe from this group and stop receiving emails from it, send an
>>
> email
>
>> to mailto:chromium-reviews+unsubscribe@chromium.org.
>>
>
> I've been waiting for the gtk code to be deleted, and then I was going to
> pick
> that CL back up.
>
> https://codereview.chromium.org/224183002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Robert Sesek, 2014-04-03 17:19:18]

On 2014/04/03 17:11:31, Nico wrote:
> …but looking for callers of NotificationUIManager::Create, it looks
> like chrome/browser/extensions/api/notifications/notifications_api.cc is
> eventually backed by the code here (?)

Right. The !OS_MACOSX ifdef in notification_ui_manager.cc should be removed
after this file is deleted. The ::Create function always
DelegatesToMessageCenter()
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/not...

[Nico, 2014-04-03 17:32:06]

On 2014/04/03 17:19:18, rsesek wrote:
> On 2014/04/03 17:11:31, Nico wrote:
> > …but looking for callers of NotificationUIManager::Create, it looks
> > like chrome/browser/extensions/api/notifications/notifications_api.cc is
> > eventually backed by the code here (?)
> 
> Right. The !OS_MACOSX ifdef in notification_ui_manager.cc should be removed
> after this file is deleted. The ::Create function always
> DelegatesToMessageCenter()
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/not...

Maybe patch set 3 works, then?

[Robert Sesek, 2014-04-03 20:19:18]

The tests pass, so lgtm I guess. There's still more code to go, though.

[Nico, 2014-04-03 20:22:04]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2014-04-03 20:23:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/224183002/30001

[commit-bot: I haz the power, 2014-04-03 20:24:56]

Change committed as 261516