Presentation API: fix crash when unable to create a Fragment for the dialog.

Presentation API: fix crash when unable to create a Fragment for the dialog.

If the Activity is destroyed while the dialog is open, the Android
support library will try to cerate the dialog again with an empty
constructor provoking a crash because we did not implement such
constructor.

This CL fixes the issue by adding a default constructor that is going to
automatically dismiss the dialogs.

BUG=634828
Committed: https://crrev.com/12d7a52a6d5b67dade50366a2c44f186850f8bce
Cr-Commit-Position: refs/heads/master@{#411678}

[mlamouri (slow - plz ping), 2016-08-12 15:49:23]

mlamouri@chromium.org changed reviewers:
+ zqzhang@chromium.org

[mlamouri (slow - plz ping), 2016-08-12 15:49:23]

Zhiqiang, PTAL :)

[mlamouri (slow - plz ping), 2016-08-12 15:49:27]

The CQ bit was checked by mlamouri@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 15:49:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Zhiqiang Zhang (Slow), 2016-08-12 16:18:53]

lgtm /nit

https://codereview.chromium.org/2241803002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/media/router/MediaRouteChooserDialogManager.java
(right):

https://codereview.chromium.org/2241803002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/media/router/MediaRouteChooserDialogManager.java:33:
private boolean mCancelled;
Init explicitly with false? It's null if uninitialized.

[mlamouri (slow - plz ping), 2016-08-12 16:21:29]

Thanks for the quick review! :)

https://codereview.chromium.org/2241803002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/media/router/MediaRouteChooserDialogManager.java
(right):

https://codereview.chromium.org/2241803002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/media/router/MediaRouteChooserDialogManager.java:33:
private boolean mCancelled;
On 2016/08/12 at 16:18:53, Zhiqiang Zhang wrote:
> Init explicitly with false? It's null if uninitialized.

It's a `boolean`, not a `Boolean` ;)

[mlamouri (slow - plz ping), 2016-08-12 16:21:34]

The CQ bit was unchecked by mlamouri@chromium.org

[mlamouri (slow - plz ping), 2016-08-12 16:21:36]

The CQ bit was checked by mlamouri@chromium.org

[commit-bot: I haz the power, 2016-08-12 16:21:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 16:50:02]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-12 16:52:28]

Description was changed from

==========
Presentation API: fix crash when unable to create a Fragment for the dialog.

If the Activity is destroyed while the dialog is open, the Android
support library will try to cerate the dialog again with an empty
constructor provoking a crash because we did not implement such
constructor.

This CL fixes the issue by adding a default constructor that is going to
automatically dismiss the dialogs.

BUG=634828
==========

to

==========
Presentation API: fix crash when unable to create a Fragment for the dialog.

If the Activity is destroyed while the dialog is open, the Android
support library will try to cerate the dialog again with an empty
constructor provoking a crash because we did not implement such
constructor.

This CL fixes the issue by adding a default constructor that is going to
automatically dismiss the dialogs.

BUG=634828

Committed: https://crrev.com/12d7a52a6d5b67dade50366a2c44f186850f8bce
Cr-Commit-Position: refs/heads/master@{#411678}
==========

[commit-bot: I haz the power, 2016-08-12 16:52:29]

Patchset 1 (id:??) landed as
https://crrev.com/12d7a52a6d5b67dade50366a2c44f186850f8bce
Cr-Commit-Position: refs/heads/master@{#411678}