Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2241763002: cc: fix damage tracker rect with hidpi filters. (Closed)

Created:
4 years, 4 months ago by Stephen White
Modified:
4 years, 4 months ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: fix damage tracker rect with hidpi filters. BUG=624027 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/2bc7c6121856f959d907ec52e0aadf43d7a39616 Cr-Commit-Position: refs/heads/master@{#411734}

Patch Set 1 #

Patch Set 2 : Add unit test #

Total comments: 1

Patch Set 3 : Fix comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -5 lines) Patch
M cc/layers/render_surface_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/layers/render_surface_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M cc/trees/damage_tracker.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/trees/damage_tracker_unittest.cc View 1 2 5 chunks +56 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_host_common.h View 1 1 chunk +9 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_common.cc View 1 2 chunks +25 lines, -1 line 0 comments Download

Messages

Total messages: 34 (21 generated)
Stephen White
enne@: PTAL. Thanks!
4 years, 4 months ago (2016-08-12 15:54:19 UTC) #10
enne (OOO)
lgtm in general https://codereview.chromium.org/2241763002/diff/20001/cc/trees/damage_tracker_unittest.cc File cc/trees/damage_tracker_unittest.cc (right): https://codereview.chromium.org/2241763002/diff/20001/cc/trees/damage_tracker_unittest.cc#newcode706 cc/trees/damage_tracker_unittest.cc:706: // Setting the update rect should ...
4 years, 4 months ago (2016-08-12 17:34:34 UTC) #13
Stephen White
On 2016/08/12 17:34:34, enne wrote: > lgtm in general > > https://codereview.chromium.org/2241763002/diff/20001/cc/trees/damage_tracker_unittest.cc > File cc/trees/damage_tracker_unittest.cc ...
4 years, 4 months ago (2016-08-12 17:41:45 UTC) #14
Stephen White
On 2016/08/12 17:41:45, Stephen White wrote: > On 2016/08/12 17:34:34, enne wrote: > > lgtm ...
4 years, 4 months ago (2016-08-12 17:47:40 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2241763002/40001
4 years, 4 months ago (2016-08-12 17:48:34 UTC) #18
commit-bot: I haz the power
Exceeded global retry quota
4 years, 4 months ago (2016-08-12 18:10:20 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2241763002/40001
4 years, 4 months ago (2016-08-12 18:12:28 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/111693)
4 years, 4 months ago (2016-08-12 18:18:12 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2241763002/40001
4 years, 4 months ago (2016-08-12 18:19:17 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/272839)
4 years, 4 months ago (2016-08-12 18:40:41 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2241763002/40001
4 years, 4 months ago (2016-08-12 18:42:09 UTC) #30
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-12 19:34:58 UTC) #32
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 19:37:46 UTC) #34
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2bc7c6121856f959d907ec52e0aadf43d7a39616
Cr-Commit-Position: refs/heads/master@{#411734}

Powered by Google App Engine
This is Rietveld 408576698