[Android] Fix icu_use_data_file = false.

content/app/content_main_runner.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/public/app/content_main_runner.h"
 
 #include <stddef.h>
 #include <stdlib.h>
 #include <string.h>
 
@@ skipping 453 matching lines @@
 #else  // !OS_WIN
 
 #if defined(OS_ANDROID)
     // See note at the initialization of ExitManager, below; basically,
     // only Android builds have the ctor/dtor handlers set up to use
     // TRACE_EVENT right away.
     TRACE_EVENT0("startup,benchmark,rail", "ContentMainRunnerImpl::Initialize");
 #endif  // OS_ANDROID
 
     base::GlobalDescriptors* g_fds = base::GlobalDescriptors::GetInstance();
+    ALLOW_UNUSED_LOCAL(g_fds);

[jungshik at Google, 2016/08/19 23:10:48]

I wonder if it'd be better to enclose |base::Glo...g_fds = ...| with 

#if !defined(OS_ANDROID) || (ICU_UTIL_DATA_IMPL == ICU_UTIL_DATA_FILE)

instead of ALLOW_UNUSED_LOCAL(g_fds). 

[Eden Wang, 2016/08/20 00:41:42]

I think it would be a very long statement to enclose |base::Glo...g_fds = ...|,
because g_fds is used for

!defined(OS_ANDROID)
defined(OS_LINUX) || defined(OS_OPENBSD)
defined(OS_ANDROID) && (ICU_UTIL_DATA_IMPL == ICU_UTIL_DATA_FILE)
defined(V8_USE_EXTERNAL_STARTUP_DATA) && defined(OS_POSIX) &&
!defined(OS_MACOSX)

and this statement is not stable, we need add more conditions after any other fd
has been accessed.

[jungshik at Google, 2016/08/22 20:02:00]

I don't think you need that long condition. The short condition I gave 
seems sufficient because g_fds is used right below for setlocale when OS !=
Android. 
Having to change the condition (when that's not the case any more) is a
downside, though. 

Anyway, it's not a big deal. I'm ok with ALLOW..LOCALE. 

 
     // On Android,
     // - setlocale() is not supported.
     // - We do not override the signal handlers so that we can get
     //   stack trace when crashing.
     // - The ipc_fd is passed through the Java service.
     // Thus, these are all disabled.
 #if !defined(OS_ANDROID)
     // Set C library locale to make sure CommandLine can parse argument values
     // in correct encoding.
@@ skipping 187 matching lines @@
 #endif
 
 #if defined(USE_NSS_CERTS)
     crypto::EarlySetupForNSSInit();
 #endif
 
     ui::RegisterPathProvider();
     RegisterPathProvider();
     RegisterContentSchemes(true);
 
-#if defined(OS_ANDROID)
+#if defined(OS_ANDROID) && (ICU_UTIL_DATA_IMPL == ICU_UTIL_DATA_FILE)
     int icudata_fd = g_fds->MaybeGet(kAndroidICUDataDescriptor);
     if (icudata_fd != -1) {
       auto icudata_region = g_fds->GetRegion(kAndroidICUDataDescriptor);
       CHECK(base::i18n::InitializeICUWithFileDescriptor(icudata_fd,
                                                         icudata_region));
     } else {
       CHECK(base::i18n::InitializeICU());
     }
 #else
     CHECK(base::i18n::InitializeICU());
-#endif  // OS_ANDROID
+#endif  // OS_ANDROID && (ICU_UTIL_DATA_IMPL == ICU_UTIL_DATA_FILE)
 
     base::StatisticsRecorder::Initialize();
 
 #if defined(V8_USE_EXTERNAL_STARTUP_DATA)
 #if defined(OS_POSIX) && !defined(OS_MACOSX)
 #if !defined(OS_ANDROID)
     // kV8NativesDataDescriptor and kV8SnapshotDataDescriptor could be shared
     // with child processes via file descriptors. On Android they are set in
     // ChildProcessService::InternalInitChildProcess, otherwise set them here.
     if (command_line.HasSwitch(switches::kV8NativesPassedByFD)) {
@@ skipping 138 matching lines @@
 
   DISALLOW_COPY_AND_ASSIGN(ContentMainRunnerImpl);
 };
 
 // static
 ContentMainRunner* ContentMainRunner::Create() {
   return new ContentMainRunnerImpl();
 }
 
 }  // namespace content