Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Issue 2241743002: Do not reuse opaque Resource from a service worker for non no-cors requests (Closed)

Created:
4 years, 4 months ago by hiroshige
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, Yoav Weiss, tzik, serviceworker-reviews, tyoshino+watch_chromium.org, nhiroki, falken, kinuko+serviceworker, gavinp+loader_chromium.org, loading-reviews+fetch_chromium.org, blink-reviews, horo+watch_chromium.org, Nate Chapin
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Do not reuse opaque Resource from a service worker for non no-cors requests RespondWithObserver::responseWasFulfilled() rejects FetchResponseData::OpaqueType for requests that are not WebURLRequest::FetchRequestModeNoCORS, but this check is not in MemoryCache. BUG=625575 Review-Url: https://codereview.chromium.org/2177283006 Cr-Commit-Position: refs/heads/master@{#410052} (cherry picked from commit 77317690ae5f0d6e60ea0b2693085ed5b9b2df09)

Patch Set 1 #

Messages

Total messages: 2 (1 generated)
hiroshige
4 years, 4 months ago (2016-08-16 06:00:38 UTC) #2
Message was sent while issue was closed.
This CL is already landed to M-53.
https://bugs.chromium.org/p/chromium/issues/detail?id=625575#c17

Powered by Google App Engine
This is Rietveld 408576698