Issue 224173002: Revert of Use apps::AppEventRouter to launch app_shell apps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 224173002: Revert of Use apps::AppEventRouter to launch app_shell apps (Closed)

Created:
6 years, 8 months ago by James Cook

Modified:
6 years, 8 months ago

Reviewers:
Ken Rockot(use gerrit already)

CC:
chromium-reviews, tfarina, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Revert of Use apps::AppEventRouter to launch app_shell apps (https://codereview.chromium.org/219513005/) Reason for revert: This creates an unwanted dependency from app_shell back onto apps (we're moving it to depend only on extensions to keep the binary small). Original issue's description: > Use apps::AppEventRouter to launch app_shell apps > > Now that the app_runtime API has moved to //apps we can eliminate a small > amount of code duplication in app_shell. > > BUG=357818 > TEST=app_shell launches calculator > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260647 TBR=rockot@chromium.org NOTRY=true BUG=357818 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261455