Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issue 2241723002: Use https for naver search engine (Closed)

Created:
4 years, 4 months ago by jihoon
Modified:
4 years, 4 months ago
Reviewers:
SteveT, Peter Kasting
CC:
chromium-reviews, vasilii+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use https for naver search engine Naver search engine has been providing https support for some time now. Current http url even automatically redirects to https, So changing naver urls to https where appropriate. BUG= Committed: https://crrev.com/c33c68d1a0e8cc2374b3b23255048313fbd0fe4b Cr-Commit-Position: refs/heads/master@{#411584}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Use https for naver search engine #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M AUTHORS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M components/search_engines/prepopulated_engines.json View 1 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
jihoon
4 years, 4 months ago (2016-08-12 06:58:16 UTC) #3
Peter Kasting
LGTM with one fix https://codereview.chromium.org/2241723002/diff/1/components/search_engines/prepopulated_engines.json File components/search_engines/prepopulated_engines.json (right): https://codereview.chromium.org/2241723002/diff/1/components/search_engines/prepopulated_engines.json#newcode33 components/search_engines/prepopulated_engines.json:33: "kCurrentDataVersion": 91 You need to ...
4 years, 4 months ago (2016-08-12 07:02:28 UTC) #4
Peter Kasting
Also, I don't see your email in the AUTHORS list. Have you contributed before? If ...
4 years, 4 months ago (2016-08-12 07:04:28 UTC) #5
jihoon
Done. Signed the CLA && Added my emails.
4 years, 4 months ago (2016-08-12 07:47:00 UTC) #6
jihoon
4 years, 4 months ago (2016-08-12 07:47:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2241723002/20001
4 years, 4 months ago (2016-08-12 08:02:28 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-12 08:36:42 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 08:38:32 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c33c68d1a0e8cc2374b3b23255048313fbd0fe4b
Cr-Commit-Position: refs/heads/master@{#411584}

Powered by Google App Engine
This is Rietveld 408576698