Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 22417002: Rename ASSERT_NO_EXCEPTION_STATE and IGNORE_EXCEPTION_STATE (Closed)

Created:
7 years, 4 months ago by arv (Not doing code reviews)
Modified:
7 years, 4 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, Steve Block, shans, eae+blinkwatch, Mike Lawther (Google), apavlov+blink_chromium.org, adamk+blink_chromium.org, pdr, rjwright, aandrey+blink_chromium.org, do-not-use, Nils Barth (inactive), caseq+blink_chromium.org, Nate Chapin, aboxhall, dstockwell, alecflett, yurys+blink_chromium.org, Timothy Loh, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, Rik, jchaffraix+rendering, devtools-reviews_chromium.org, Eric Willigers, alancutter (OOO until 2018), loislo+blink_chromium.org, lushnikov+blink_chromium.org, feature-media-reviews_chromium.org, dmazzoni, darktears, haraken, kojih, vcarbune.chromium, jsbell, jsbell+bindings_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, leviw+renderwatch, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, f(malita), chromiumbugtracker_adobe.com, dgrogan, Stephen Chennney, jeez
Visibility:
Public.

Description

Rename ASSERT_NO_EXCEPTION_STATE and IGNORE_EXCEPTION_STATE ASSERT_NO_EXCEPTION_STATE to ASSERT_NO_EXCEPTION IGNORE_EXCEPTION_STATE to IGNORE_EXCEPTION The *_STATE name was just temporary and needed during the transition BUG=NONE TBR=abarth Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155609

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+373 lines, -373 lines) Patch
M Source/bindings/v8/ExceptionStatePlaceholder.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/accessibility/AccessibilityRenderObject.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/dom/Attr.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ContainerNode.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/dom/ContainerNode.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/DecodedDataDocumentParser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Document.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/MessagePort.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Node.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/dom/Range.h View 2 chunks +8 lines, -8 lines 0 comments Download
M Source/core/dom/Range.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/Text.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/AppendNodeCommand.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/CompositeEditCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/DeleteFromTextNodeCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/EditingStyle.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/Editor.cpp View 19 chunks +26 lines, -26 lines 0 comments Download
M Source/core/editing/EditorCommand.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/editing/FormatBlockCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/InsertIntoTextNodeCommand.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/InsertListCommand.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/InsertNodeBeforeCommand.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/MergeIdenticalElementsCommand.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/RemoveCSSPropertyCommand.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/RemoveNodeCommand.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/ReplaceNodeWithSpanCommand.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/editing/ReplaceSelectionCommand.cpp View 6 chunks +10 lines, -10 lines 0 comments Download
M Source/core/editing/SplitElementCommand.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/SplitTextNodeCommand.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/TextCheckingHelper.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/TextInsertionBaseCommand.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/TextIterator.cpp View 10 chunks +20 lines, -20 lines 0 comments Download
M Source/core/editing/VisibleUnits.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/WrapContentsInDummySpanCommand.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/editing/htmlediting.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/markup.cpp View 14 chunks +20 lines, -20 lines 0 comments Download
M Source/core/html/BaseChooserOnlyDateAndTimeInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/ColorInputType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/FileInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLDetailsElement.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLKeygenElement.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 6 chunks +7 lines, -7 lines 0 comments Download
M Source/core/html/HTMLMeterElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLOutputElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLProgressElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLScriptElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLSelectElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLSummaryElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLTableElement.cpp View 4 chunks +7 lines, -7 lines 0 comments Download
M Source/core/html/HTMLTextAreaElement.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M Source/core/html/HTMLTextFormControlElement.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/html/HTMLTitleElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTrackElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/ImageDocument.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/html/InputType.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/html/MediaController.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/MediaDocument.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/html/PluginDocument.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/RangeInputType.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/SearchInputType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/TextFieldInputType.cpp View 3 chunks +9 lines, -9 lines 0 comments Download
M Source/core/html/TimeRanges.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/TimeRangesTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/WebGLRenderingContext.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/parser/HTMLTreeBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/shadow/DateTimeEditElement.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/shadow/MediaControlElementTypes.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/shadow/MediaControlElements.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/shadow/MediaControls.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/shadow/MediaControlsChromium.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/shadow/MediaControlsChromiumAndroid.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/track/InbandTextTrack.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/html/track/TextTrack.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/track/TextTrackCue.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/track/TextTrackList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/track/TextTrackRegion.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/inspector/DOMEditor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/DOMPatchSupport.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorCSSAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorDatabaseAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorFileSystemAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorHistory.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorIndexedDBAgent.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorResourceAgent.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/inspector/InspectorStyleSheet.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/page/DOMSelection.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/page/DOMWindow.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/page/DragController.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/page/EventHandler.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M Source/core/page/FrameActionScheduler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/chromium/ChromiumDataObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderMediaControlsChromium.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderNamedFlowThread.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/rendering/style/SVGRenderStyle.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGAnimatedAngle.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGAnimatedLength.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGAnimatedLengthList.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGDocument.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGLength.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGTRefElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGTextContentElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGUseElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/animation/SVGSMILElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/testing/Internals.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/testing/MockPagePopupDriver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/XMLTreeViewer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/parser/XMLDocumentParser.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/indexeddb/IDBDatabase.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/indexeddb/IDBObjectStore.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/indexeddb/IDBRequest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/indexeddb/IDBTransaction.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediasource/MediaSource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediasource/MediaSourceBase.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/mediasource/WebKitMediaSource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/websockets/MainThreadWebSocketChannel.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/ApplicationCacheHost.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/ContextMenuClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebFrameImpl.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/web/WebRange.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/mac/WebSubstringUtil.mm View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/CustomEventTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/LinkHighlightTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
arv (Not doing code reviews)
7 years, 4 months ago (2013-08-06 13:05:57 UTC) #1
Message was sent while issue was closed. 
Committed patchset #1 manually as r155609 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698