Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 2241693002: X87: Use IsPropertyName instead of IsInternalizedString in VisitObjectLiteral. (Closed)

Created:
4 years, 4 months ago by zhengxing.li
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Use IsPropertyName instead of IsInternalizedString in VisitObjectLiteral. port 51e9d5ad2a75a08fc9d9349d35718f50ef099bb3 (r38577) original commit message: Use IsPropertyName in VisitObjectLiteral to decide whether to do a named property store or call SetProperty. BUG= Committed: https://crrev.com/64658b6c286b62392c7cfca0af44f8f5589c6e24 Cr-Commit-Position: refs/heads/master@{#38595}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 4 months ago (2016-08-12 02:19:19 UTC) #2
Weiliang
lgtm
4 years, 4 months ago (2016-08-12 03:14:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2241693002/1
4 years, 4 months ago (2016-08-12 05:27:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-12 05:49:05 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 05:49:29 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/64658b6c286b62392c7cfca0af44f8f5589c6e24
Cr-Commit-Position: refs/heads/master@{#38595}

Powered by Google App Engine
This is Rietveld 408576698