chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc - Issue 2241673002: Make UnsafeResource hold a WebContents getter instead of RenderFrame ids

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc

Issue 2241673002: Make UnsafeResource hold a WebContents getter instead of RenderFrame ids (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc ('k') | chrome/browser/safe_browsing/threat_details_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc

diff --git a/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc b/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc

index de3da1eccf9982081ef04f0c20691ed967b4aa26..b4ffbd35996b9acb7736c818807e5385b8c29642 100644

--- a/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc

+++ b/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc

@@ -217,9 +217,10 @@ class SafeBrowsingBlockingPageTest : public ChromeRenderViewHostTestHarness {

resource->url = url;

resource->is_subresource = is_subresource;

resource->threat_type = SB_THREAT_TYPE_URL_MALWARE;

- resource->render_process_host_id =

- web_contents()->GetRenderProcessHost()->GetID();

- resource->render_frame_id = web_contents()->GetMainFrame()->GetRoutingID();

+ resource->web_contents_getter =

+ SafeBrowsingUIManager::UnsafeResource::GetWebContentsGetter(

+ web_contents()->GetRenderProcessHost()->GetID(),

+ web_contents()->GetMainFrame()->GetRoutingID());

resource->threat_source = safe_browsing::ThreatSource::LOCAL_PVER3;

}