third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp - Issue 2241663002: Take CSS Clip and contain: paint into account when computing visual rects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

Issue 2241663002: Take CSS Clip and contain: paint into account when computing visual rects. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: none Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp ('k') | third_party/WebKit/Source/core/paint/PaintLayer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp b/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

index 57cfc9ebe551b980838e02bad3c29dddd71c6cfb..5eecea33f8aaaed42a80ed7258f8f5c4f0044142 100644

--- a/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

+++ b/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

@@ -581,14 +581,8 @@ bool CompositedLayerMapping::updateGraphicsLayerConfiguration()

static IntRect clipBox(LayoutBox* layoutObject)

{

- LayoutRect result = LayoutRect(LayoutRect::infiniteIntRect());

- if (layoutObject->hasOverflowClip() || layoutObject->style()->containsPaint())

- result = layoutObject->overflowClipRect(LayoutPoint());

- if (layoutObject->hasClip())

- result.intersect(layoutObject->clipRect(LayoutPoint()));

- return pixelSnappedIntRect(result);

+ // TODO(chrishtr): pixel snapping is most likely incorrect here.

+ return pixelSnappedIntRect(layoutObject->clippingRect());

}

static LayoutPoint computeOffsetFromCompositedAncestor(const PaintLayer* layer, const PaintLayer* compositedAncestor)