Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3197)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/TabContentViewParent.java

Issue 2241643003: Fix a bug that some NativePage might overlap tabstrip on tablets (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/tab/TabContentViewParent.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabContentViewParent.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/TabContentViewParent.java
index 865893db766234191a4cc399582f7d84a0826726..d2104ad73fdaa5a11cc629e3337634e07cbeb60a 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabContentViewParent.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/TabContentViewParent.java
@@ -7,6 +7,7 @@ package org.chromium.chrome.browser.tab;
import android.content.Context;
import android.support.design.widget.CoordinatorLayout;
import android.support.design.widget.CoordinatorLayout.Behavior;
+import android.view.Gravity;
import android.view.View;
import android.widget.FrameLayout;
@@ -43,9 +44,16 @@ public class TabContentViewParent extends FrameLayout {
}
removeCurrentContent();
+ LayoutParams lp = (LayoutParams) viewToShow.getLayoutParams();
+ if (lp == null) {
+ lp = new LayoutParams(LayoutParams.MATCH_PARENT, LayoutParams.MATCH_PARENT);
+ }
+ // Weirdly enough, if gravity is not top, top_margin is not respected by FrameLayout.
+ // Yet for many native pages on tablet, top_margin is necessary to not overlap the tab
+ // switcher.
+ lp.gravity = Gravity.TOP;
UiUtils.removeViewFromParent(viewToShow);
- addView(viewToShow, CONTENT_INDEX, new FrameLayout.LayoutParams(
- LayoutParams.MATCH_PARENT, LayoutParams.MATCH_PARENT));
+ addView(viewToShow, CONTENT_INDEX, lp);
viewToShow.requestFocus();
}
};
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698