Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5181)

Unified Diff: chrome/common/extensions/features/base_feature_provider.h

Issue 224163002: Move core features code to //extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: move tests Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/features/base_feature_provider.h
diff --git a/chrome/common/extensions/features/base_feature_provider.h b/chrome/common/extensions/features/base_feature_provider.h
deleted file mode 100644
index 4fcb2f2d6e1a8491a05348c693eb7078bde2e4ca..0000000000000000000000000000000000000000
--- a/chrome/common/extensions/features/base_feature_provider.h
+++ /dev/null
@@ -1,53 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef CHROME_COMMON_EXTENSIONS_FEATURES_BASE_FEATURE_PROVIDER_H_
-#define CHROME_COMMON_EXTENSIONS_FEATURES_BASE_FEATURE_PROVIDER_H_
-
-#include <map>
-#include <string>
-#include <vector>
-
-#include "base/memory/linked_ptr.h"
-#include "base/values.h"
-#include "chrome/common/extensions/features/simple_feature.h"
-#include "extensions/common/features/feature_provider.h"
-
-namespace extensions {
-
-// Reads Features out of a simple JSON file description.
-class BaseFeatureProvider : public FeatureProvider {
- public:
- typedef SimpleFeature*(*FeatureFactory)();
-
- // Creates a new BaseFeatureProvider. Pass null to |factory| to have the
- // provider create plain old Feature instances.
- BaseFeatureProvider(const base::DictionaryValue& root,
- FeatureFactory factory);
- virtual ~BaseFeatureProvider();
-
- // Gets a feature provider for a specific feature type, like "permission".
- static FeatureProvider* GetByName(const std::string& name);
-
- // Gets the feature |feature_name|, if it exists.
- virtual Feature* GetFeature(const std::string& feature_name) const OVERRIDE;
- virtual Feature* GetParent(Feature* feature) const OVERRIDE;
- virtual std::vector<Feature*> GetChildren(const Feature& parent) const
- OVERRIDE;
-
- virtual const std::vector<std::string>& GetAllFeatureNames() const OVERRIDE;
-
- private:
- typedef std::map<std::string, linked_ptr<Feature> > FeatureMap;
- FeatureMap features_;
-
- // Populated on first use.
- mutable std::vector<std::string> feature_names_;
-
- FeatureFactory factory_;
-};
-
-} // namespace extensions
-
-#endif // CHROME_COMMON_EXTENSIONS_FEATURES_BASE_FEATURE_PROVIDER_H_

Powered by Google App Engine
This is Rietveld 408576698