Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4864)

Unified Diff: chrome/common/extensions/features/base_feature_provider.cc

Issue 224163002: Move core features code to //extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: move tests Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/features/base_feature_provider.cc
diff --git a/chrome/common/extensions/features/base_feature_provider.cc b/chrome/common/extensions/features/base_feature_provider.cc
deleted file mode 100644
index be4def3fb22546acb52d1d22ae77422050d840b5..0000000000000000000000000000000000000000
--- a/chrome/common/extensions/features/base_feature_provider.cc
+++ /dev/null
@@ -1,249 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "chrome/common/extensions/features/base_feature_provider.h"
-
-#include <stack>
-
-#include "base/json/json_reader.h"
-#include "base/lazy_instance.h"
-#include "base/strings/string_split.h"
-#include "base/strings/string_util.h"
-#include "chrome/common/extensions/features/api_feature.h"
-#include "chrome/common/extensions/features/complex_feature.h"
-#include "chrome/common/extensions/features/manifest_feature.h"
-#include "chrome/common/extensions/features/permission_feature.h"
-#include "extensions/common/extensions_client.h"
-#include "grit/common_resources.h"
-#include "ui/base/resource/resource_bundle.h"
-
-namespace extensions {
-
-namespace {
-
-template<class FeatureClass>
-SimpleFeature* CreateFeature() {
- SimpleFeature* feature = new FeatureClass();
- ExtensionsClient::Get()->AddExtraFeatureFilters(feature);
- return feature;
-}
-
-static BaseFeatureProvider* LoadProvider(
- const std::string& name,
- BaseFeatureProvider::FeatureFactory factory,
- int resource_id) {
- const std::string& features_file =
- ResourceBundle::GetSharedInstance().GetRawDataResource(
- resource_id).as_string();
- int error_code = 0;
- std::string error_message;
- scoped_ptr<base::Value> value(base::JSONReader::ReadAndReturnError(
- features_file, base::JSON_PARSE_RFC,
- &error_code, &error_message));
- DCHECK(value) << "Could not load features: " << name << " "
- << error_message;
- scoped_ptr<base::DictionaryValue> value_as_dict;
- if (value) {
- CHECK(value->IsType(base::Value::TYPE_DICTIONARY)) << name;
- value_as_dict.reset(static_cast<base::DictionaryValue*>(value.release()));
- } else {
- // http://crbug.com/176381
- value_as_dict.reset(new base::DictionaryValue());
- }
- return new BaseFeatureProvider(*value_as_dict, factory);
-}
-
-struct Static {
- Static() {
- feature_providers["api"] = make_linked_ptr(
- LoadProvider("api",
- &CreateFeature<APIFeature>,
- IDR_EXTENSION_API_FEATURES));
- feature_providers["permission"] = make_linked_ptr(
- LoadProvider("permission",
- &CreateFeature<PermissionFeature>,
- IDR_EXTENSION_PERMISSION_FEATURES));
- feature_providers["manifest"] = make_linked_ptr(
- LoadProvider("manifest",
- &CreateFeature<ManifestFeature>,
- IDR_EXTENSION_MANIFEST_FEATURES));
- }
-
- typedef std::map<std::string, linked_ptr<FeatureProvider> >
- FeatureProviderMap;
-
- FeatureProvider* GetFeatures(const std::string& name) const {
- FeatureProviderMap::const_iterator it = feature_providers.find(name);
- CHECK(it != feature_providers.end());
- return it->second.get();
- }
-
- FeatureProviderMap feature_providers;
-};
-
-base::LazyInstance<Static> g_static = LAZY_INSTANCE_INITIALIZER;
-
-bool ParseFeature(const base::DictionaryValue* value,
- const std::string& name,
- SimpleFeature* feature) {
- feature->set_name(name);
- std::string error = feature->Parse(value);
- if (!error.empty())
- LOG(ERROR) << error;
- return error.empty();
-}
-
-} // namespace
-
-BaseFeatureProvider::BaseFeatureProvider(const base::DictionaryValue& root,
- FeatureFactory factory)
- : factory_(factory ? factory :
- static_cast<FeatureFactory>(&CreateFeature<SimpleFeature>)) {
- for (base::DictionaryValue::Iterator iter(root); !iter.IsAtEnd();
- iter.Advance()) {
- if (iter.value().GetType() == base::Value::TYPE_DICTIONARY) {
- linked_ptr<SimpleFeature> feature((*factory_)());
-
- std::vector<std::string> split;
- base::SplitString(iter.key(), '.', &split);
-
- // Push parent features on the stack, starting with the current feature.
- // If one of the features has "noparent" set, stop pushing features on
- // the stack. The features will then be parsed in order, starting with
- // the farthest parent that is either top level or has "noparent" set.
- std::stack<std::pair<std::string, const base::DictionaryValue*> >
- parse_stack;
- while (!split.empty()) {
- std::string parent_name = JoinString(split, '.');
- split.pop_back();
- if (root.HasKey(parent_name)) {
- const base::DictionaryValue* parent = NULL;
- CHECK(root.GetDictionaryWithoutPathExpansion(parent_name, &parent));
- parse_stack.push(std::make_pair(parent_name, parent));
- bool no_parent = false;
- parent->GetBoolean("noparent", &no_parent);
- if (no_parent)
- break;
- }
- }
-
- CHECK(!parse_stack.empty());
- // Parse all parent features.
- bool parse_error = false;
- while (!parse_stack.empty()) {
- if (!ParseFeature(parse_stack.top().second,
- parse_stack.top().first,
- feature.get())) {
- parse_error = true;
- break;
- }
- parse_stack.pop();
- }
-
- if (parse_error)
- continue;
-
- features_[iter.key()] = feature;
- } else if (iter.value().GetType() == base::Value::TYPE_LIST) {
- // This is a complex feature.
- const base::ListValue* list =
- static_cast<const base::ListValue*>(&iter.value());
- CHECK_GT(list->GetSize(), 0UL);
-
- scoped_ptr<ComplexFeature::FeatureList> features(
- new ComplexFeature::FeatureList());
-
- // Parse and add all SimpleFeatures from the list.
- for (base::ListValue::const_iterator list_iter = list->begin();
- list_iter != list->end(); ++list_iter) {
- if ((*list_iter)->GetType() != base::Value::TYPE_DICTIONARY) {
- LOG(ERROR) << iter.key() << ": Feature rules must be dictionaries.";
- continue;
- }
-
- scoped_ptr<SimpleFeature> feature((*factory_)());
- if (!ParseFeature(static_cast<const base::DictionaryValue*>(*list_iter),
- iter.key(),
- feature.get()))
- continue;
-
- features->push_back(feature.release());
- }
-
- linked_ptr<ComplexFeature> feature(new ComplexFeature(features.Pass()));
- feature->set_name(iter.key());
-
- features_[iter.key()] = feature;
- } else {
- LOG(ERROR) << iter.key() << ": Feature description must be dictionary or"
- << " list of dictionaries.";
- }
- }
-}
-
-BaseFeatureProvider::~BaseFeatureProvider() {
-}
-
-// static
-FeatureProvider* BaseFeatureProvider::GetByName(
- const std::string& name) {
- return g_static.Get().GetFeatures(name);
-}
-
-const std::vector<std::string>& BaseFeatureProvider::GetAllFeatureNames()
- const {
- if (feature_names_.empty()) {
- for (FeatureMap::const_iterator iter = features_.begin();
- iter != features_.end(); ++iter) {
- feature_names_.push_back(iter->first);
- }
- // A std::map is sorted by its keys, so we don't need to sort feature_names_
- // now.
- }
- return feature_names_;
-}
-
-Feature* BaseFeatureProvider::GetFeature(const std::string& name) const {
- FeatureMap::const_iterator iter = features_.find(name);
- if (iter != features_.end())
- return iter->second.get();
- else
- return NULL;
-}
-
-Feature* BaseFeatureProvider::GetParent(Feature* feature) const {
- CHECK(feature);
- if (feature->no_parent())
- return NULL;
-
- std::vector<std::string> split;
- base::SplitString(feature->name(), '.', &split);
- if (split.size() < 2)
- return NULL;
- split.pop_back();
- return GetFeature(JoinString(split, '.'));
-}
-
-// Children of a given API are named starting with parent.name()+".", which
-// means they'll be contiguous in the features_ std::map.
-std::vector<Feature*> BaseFeatureProvider::GetChildren(const Feature& parent)
- const {
- std::string prefix = parent.name() + ".";
- const FeatureMap::const_iterator first_child = features_.lower_bound(prefix);
-
- // All children have names before (parent.name() + ('.'+1)).
- ++prefix[prefix.size() - 1];
- const FeatureMap::const_iterator after_children =
- features_.lower_bound(prefix);
-
- std::vector<Feature*> result;
- result.reserve(std::distance(first_child, after_children));
- for (FeatureMap::const_iterator it = first_child; it != after_children;
- ++it) {
- result.push_back(it->second.get());
- }
- return result;
-}
-
-} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698