Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1540)

Unified Diff: blimp/client/core/contents/blimp_contents_manager.h

Issue 2241623002: blimp: Move compositing, input and render widget feature to client/core. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed comments from #7 Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/client/core/contents/blimp_contents_manager.h
diff --git a/blimp/client/core/contents/blimp_contents_manager.h b/blimp/client/core/contents/blimp_contents_manager.h
index ea70960ffbccffc7eb48072e9d5784c2de681fab..deee73f5bbf423cb48b0d2781e67d688c19a716f 100644
--- a/blimp/client/core/contents/blimp_contents_manager.h
+++ b/blimp/client/core/contents/blimp_contents_manager.h
@@ -5,17 +5,19 @@
#ifndef BLIMP_CLIENT_CORE_CONTENTS_BLIMP_CONTENTS_MANAGER_H_
#define BLIMP_CLIENT_CORE_CONTENTS_BLIMP_CONTENTS_MANAGER_H_
+#include "blimp/client/core/compositor/compositor_deps_provider.h"
#include "blimp/client/core/contents/blimp_contents_impl.h"
namespace blimp {
namespace client {
+class RenderWidgetFeature;
// BlimpContentsManager does the real work of creating BlimpContentsImpl, and
// then passes the ownership to the caller. It also owns the observers to
// monitor the life time of the contents it creates.
class BlimpContentsManager {
public:
- BlimpContentsManager();
+ explicit BlimpContentsManager(RenderWidgetFeature* render_widget_feature);
~BlimpContentsManager();
std::unique_ptr<BlimpContentsImpl> CreateBlimpContents();
@@ -40,6 +42,9 @@ class BlimpContentsManager {
// lifetime of the observers.
std::map<int, std::unique_ptr<BlimpContentsDeletionObserver>> observer_map_;
+ // The network bridge for a BlimpContents to the WebContents on the engine.
+ RenderWidgetFeature* render_widget_feature_;
+
base::WeakPtrFactory<BlimpContentsManager> weak_ptr_factory_;
DISALLOW_COPY_AND_ASSIGN(BlimpContentsManager);

Powered by Google App Engine
This is Rietveld 408576698