Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Unified Diff: blimp/client/BUILD.gn

Issue 2241623002: blimp: Move compositing, input and render widget feature to client/core. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed comments from #7 Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/client/BUILD.gn
diff --git a/blimp/client/BUILD.gn b/blimp/client/BUILD.gn
index 8c536ea8b5ecca4f9354073b3ee1d7d2e412d1b0..fe4df6e5201388359a5498199055d034c2453be4 100644
--- a/blimp/client/BUILD.gn
+++ b/blimp/client/BUILD.gn
@@ -18,11 +18,11 @@ source_set("session") {
public_deps = [
":feature",
"//blimp/client/core:switches",
+ "//blimp/client/core/render_widget",
"//ui/events",
]
deps = [
- ":compositor",
"//base",
"//blimp/client/core/compositor",
"//blimp/client/core/contents",
@@ -55,9 +55,9 @@ source_set("client") {
]
deps = [
- ":compositor",
"//base",
"//blimp/client/core",
+ "//blimp/client/core/compositor",
"//blimp/common",
"//blimp/common/proto",
"//blimp/net",
@@ -95,8 +95,6 @@ source_set("feature") {
"core/contents/tab_control_feature.h",
"feature/ime_feature.cc",
"feature/ime_feature.h",
- "feature/render_widget_feature.cc",
- "feature/render_widget_feature.h",
"feature/settings_feature.cc",
"feature/settings_feature.h",
]
@@ -125,8 +123,6 @@ source_set("test_support") {
sources = [
"feature/mock_ime_feature_delegate.cc",
"feature/mock_ime_feature_delegate.h",
- "feature/mock_render_widget_feature_delegate.cc",
- "feature/mock_render_widget_feature_delegate.h",
"session/test_client_session.cc",
"session/test_client_session.h",
]
@@ -139,70 +135,15 @@ source_set("test_support") {
]
}
-source_set("compositor") {
- sources = [
- "feature/compositor/blimp_compositor.cc",
- "feature/compositor/blimp_compositor.h",
- "feature/compositor/blimp_compositor_manager.cc",
- "feature/compositor/blimp_compositor_manager.h",
- "feature/compositor/blimp_context_provider.cc",
- "feature/compositor/blimp_context_provider.h",
- "feature/compositor/blimp_delegating_output_surface.cc",
- "feature/compositor/blimp_delegating_output_surface.h",
- "feature/compositor/blimp_gpu_memory_buffer_manager.cc",
- "feature/compositor/blimp_gpu_memory_buffer_manager.h",
- "feature/compositor/blimp_input_handler_wrapper.cc",
- "feature/compositor/blimp_input_handler_wrapper.h",
- "feature/compositor/blimp_input_manager.cc",
- "feature/compositor/blimp_input_manager.h",
- "feature/compositor/blimp_layer_tree_settings.cc",
- "feature/compositor/blimp_layer_tree_settings.h",
- "feature/compositor/blimp_output_surface.cc",
- "feature/compositor/blimp_output_surface.h",
- ]
-
- deps = [
- "//blimp/client/core/compositor",
- "//blimp/common",
- "//blimp/net",
- "//cc",
- "//cc/proto",
- "//cc/surfaces",
- "//gpu/command_buffer/client",
- "//gpu/command_buffer/client:gl_in_process_context",
- "//gpu/command_buffer/client:gles2_c_lib",
- "//gpu/command_buffer/client:gles2_implementation",
- "//gpu/command_buffer/common:gles2_utils",
- "//gpu/skia_bindings",
- "//net",
- "//skia",
- "//third_party/WebKit/public:blink_headers",
- "//third_party/libwebp",
- "//ui/base/ime:text_input_types",
- "//ui/events:gesture_detection",
- "//ui/events/blink",
- "//ui/events/gestures/blink",
- "//ui/gl",
- ]
-
- public_deps = [
- ":feature",
- "//blimp/common/proto",
- "//skia",
- ]
-}
-
source_set("feature_unit_tests") {
testonly = true
sources = [
"core/contents/tab_control_feature_unittest.cc",
- "feature/compositor/blimp_compositor_manager_unittest.cc",
- "feature/render_widget_feature_unittest.cc",
]
deps = [
- ":compositor",
+ ":feature",
":test_support",
"//base",
"//base/test:test_support",
@@ -221,11 +162,6 @@ source_set("feature_unit_tests") {
"//ui/events:gesture_detection",
"//ui/gfx/geometry",
]
-
- if (is_linux) {
- #TODO(khushalsagar): Run these tests for android.
- sources += [ "feature/compositor/blimp_compositor_unittest.cc" ]
- }
}
if (is_linux && !is_chromeos && use_x11) {
@@ -241,7 +177,9 @@ if (is_linux && !is_chromeos && use_x11) {
deps = [
":client",
"//base",
- "//blimp/client:compositor",
+ "//blimp/client/core/compositor",
+ "//blimp/client/core/compositor:compositor_support",
+ "//blimp/client/core/contents",
"//blimp/client/core/session",
"//blimp/net",
"//net",
@@ -422,8 +360,9 @@ if (is_android) {
":client",
":jni_headers",
"//base",
- "//blimp/client:compositor",
"//blimp/client/core",
+ "//blimp/client/core/compositor",
+ "//blimp/client/core/compositor:compositor_support",
"//blimp/client/core/contents",
"//blimp/client/core/session:session",
"//blimp/client/public:public_headers",
@@ -445,8 +384,6 @@ if (is_android) {
"app/android/blimp_app_jni_registrar.h",
"app/android/blimp_client_session_android.cc",
"app/android/blimp_client_session_android.h",
- "app/android/blimp_compositor_manager_android.cc",
- "app/android/blimp_compositor_manager_android.h",
"app/android/blimp_library_loader.cc",
"app/android/blimp_library_loader.h",
"app/android/blimp_view.cc",

Powered by Google App Engine
This is Rietveld 408576698