blimp: Move compositing, input and render widget feature to client/core.

blimp/client/app/android/blimp_view.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BLIMP_CLIENT_APP_ANDROID_BLIMP_VIEW_H_
 #define BLIMP_CLIENT_APP_ANDROID_BLIMP_VIEW_H_
 
 #include <memory>
 
 #include "base/android/jni_android.h"
 #include "base/macros.h"
-#include "blimp/client/app/android/blimp_compositor_manager_android.h"
+#include "base/memory/weak_ptr.h"
+#include "blimp/client/core/contents/blimp_contents_manager.h"
 #include "ui/gfx/native_widget_types.h"
 
 namespace gfx {
 class Size;
 }
 
 namespace blimp {
 namespace client {
-
+class BlimpContents;
 class RenderWidgetFeature;
 
 // The native component of org.chromium.blimp.BlimpView.  This builds and
 // maintains a BlimpCompositorAndroid and handles notifying the compositor of
 // SurfaceView surface changes (size, creation, destruction, etc.).
-class BlimpView : public BlimpCompositorManagerClient {
+class BlimpView {
  public:
   static bool RegisterJni(JNIEnv* env);
 
   // |real_size| is the total display area including system decorations (see
   // android.view.Display.getRealSize()).  |size| is the total display
   // area not including system decorations (see android.view.Display.getSize()).
   // |dp_to_px| is the scale factor that is required to convert dp (device
   // pixels) to px.
   BlimpView(JNIEnv* env,
             const base::android::JavaParamRef<jobject>& jobj,
@@ skipping 46 matching lines @@
       jfloat raw_pos_y,
       jint android_tool_type_0,
       jint android_tool_type_1,
       jint android_button_state,
       jint android_meta_state);
 
  private:
   virtual ~BlimpView();
 
   void ReleaseAcceleratedWidget();
-
-  // BlimpCompositorManagerClient implementation.
-  void OnSwapBuffersCompleted() override;
-  void DidCommitAndDrawFrame() override;
+  void OnSwapBuffersCompleted();
 
   // Reference to the Java object which owns this class.
   base::android::ScopedJavaGlobalRef<jobject> java_obj_;
 
   const float device_scale_factor_;
 
-  std::unique_ptr<BlimpCompositorManagerAndroid> compositor_manager_;
+  BlimpContentsManager blimp_contents_manager_;
+  std::unique_ptr<BlimpContentsImpl> blimp_contents_;

[nyquist, 2016/08/16 23:14:57]

I know this is temporary, but could you add a comment explaining the
relationship between these two and that we only support a single BlimpContents?

[Khushal, 2016/08/18 03:16:32]

Done. Though I think more detailed comments about these should go on
BlimpContentsManager and BlimpContents instead.

 
   // The format of the current surface owned by |compositor_|.  See
   // android.graphics.PixelFormat.java.
   int current_surface_format_;
 
   gfx::AcceleratedWidget window_;
 
+  // BlimpConnectionStatistics* blimp_connection_statistics_;
+  base::WeakPtrFactory<BlimpView> weak_ptr_factory_;
+
   DISALLOW_COPY_AND_ASSIGN(BlimpView);
 };
 
 }  // namespace client
 }  // namespace blimp
 
 #endif  // BLIMP_CLIENT_APP_ANDROID_BLIMP_VIEW_H_