gpu/command_buffer/service/gles2_cmd_copy_tex_image.h - Issue 2241593003: [Command buffer] CopyTexSubImage3D: emulate unsized format in desktop core profile

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/gles2_cmd_copy_tex_image.h

Issue 2241593003: [Command buffer] CopyTexSubImage3D: emulate unsized format in desktop core profile (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: [Command buffer] CopyTexSubImage3D: emulate unsized format in core profile Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gpu/command_buffer/service/gles2_cmd_copy_tex_image.h

diff --git a/gpu/command_buffer/service/gles2_cmd_copy_tex_image.h b/gpu/command_buffer/service/gles2_cmd_copy_tex_image.h

index 503862dab3eb7e6eab534f91ab53fbc83d328971..6dba6e1cbf465003ae2e249d62a51fbff61015e4 100644

--- a/gpu/command_buffer/service/gles2_cmd_copy_tex_image.h

+++ b/gpu/command_buffer/service/gles2_cmd_copy_tex_image.h

@@ -47,7 +47,7 @@ class GPU_EXPORT CopyTexImageResourceManager {

GLuint source_framebuffer,

GLenum source_framebuffer_internal_format);

- void DoCopyTexSubImage2DToLUMAComatabilityTexture(

+ void DoCopyTexSubImageToLUMAComatabilityTexture(

Ken Russell (switch to Gerrit) 2016/08/17 23:27:00 zmo@ just fixed a couple of typos here.

yunchao 2016/08/22 14:57:20 Done.

const gles2::GLES2Decoder* decoder,

GLuint dest_texture,

GLenum dest_texture_target,

@@ -57,6 +57,7 @@ class GPU_EXPORT CopyTexImageResourceManager {

GLint level,

GLint xoffset,

GLint yoffset,

+ GLint zoffset,

GLint x,

GLint y,

GLsizei width,

« no previous file with comments | « no previous file | gpu/command_buffer/service/gles2_cmd_copy_tex_image.cc » ('j') | gpu/command_buffer/service/gles2_cmd_decoder.cc » ('J')