Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Issue 2241563005: Handle temporary file paths in suppress.py. (Closed)

Created:
4 years, 4 months ago by estevenson
Modified:
4 years, 4 months ago
Reviewers:
agrieve
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Handle temporary file paths in suppress.py. This CL ensures that lint suppressions added with suppress.py don't depend on temporary file paths. BUG=624234 Committed: https://crrev.com/06ed71dfa04dd2cd44a4802630ddf192312ea61a Cr-Commit-Position: refs/heads/master@{#413586}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M build/android/lint/suppress.py View 3 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
estevenson
ptal Andrew!
4 years, 4 months ago (2016-08-12 17:28:41 UTC) #2
agrieve
On 2016/08/12 17:28:41, Eric Stevenson wrote: > ptal Andrew! lgtm
4 years, 4 months ago (2016-08-12 17:38:59 UTC) #3
agrieve
On 2016/08/12 17:38:59, agrieve (OOO until aug 22) wrote: > On 2016/08/12 17:28:41, Eric Stevenson ...
4 years, 4 months ago (2016-08-22 20:18:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2241563005/20001
4 years, 4 months ago (2016-08-22 20:59:08 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-22 23:52:15 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 23:53:35 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/06ed71dfa04dd2cd44a4802630ddf192312ea61a
Cr-Commit-Position: refs/heads/master@{#413586}

Powered by Google App Engine
This is Rietveld 408576698