Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 2241563003: MD Settings / User Manager: fix blurry avatar icons (Closed)

Created:
4 years, 4 months ago by Dan Beam
Modified:
4 years, 4 months ago
Reviewers:
noms (inactive)
CC:
chromium-reviews, oshima+watch_chromium.org, jlklein+watch-closure_chromium.org, dbeam+watch-elements_chromium.org, vitalyp+closure_chromium.org, michaelpg+watch-elements_chromium.org, stevenjb+watch-md-settings_chromium.org, dbeam+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings / User Manager: fix blurry avatar icons R=noms@chromium.org BUG=637156 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation NOTRY=true Committed: https://crrev.com/ecbacbc4702091d5e939f1b6aa6acbfc9d3f0664 Cr-Commit-Position: refs/heads/master@{#411973}

Patch Set 1 #

Total comments: 1

Patch Set 2 : private dance #

Patch Set 3 : all the lonely people [sections] #

Patch Set 4 : sorry, i spaced #

Patch Set 5 : fix tests #

Messages

Total messages: 27 (15 generated)
Dan Beam
https://codereview.chromium.org/2241563003/diff/1/ui/webui/resources/cr_elements/cr_profile_avatar_selector/cr_profile_avatar_selector.html File ui/webui/resources/cr_elements/cr_profile_avatar_selector/cr_profile_avatar_selector.html (right): https://codereview.chromium.org/2241563003/diff/1/ui/webui/resources/cr_elements/cr_profile_avatar_selector/cr_profile_avatar_selector.html#newcode22 ui/webui/resources/cr_elements/cr_profile_avatar_selector/cr_profile_avatar_selector.html:22: #selector .avatar { needed to override .keyboard-focus
4 years, 4 months ago (2016-08-12 01:29:54 UTC) #2
Dan Beam
proof i actually tried it ;) https://bugs.chromium.org/p/chromium/issues/detail?id=637156#c2
4 years, 4 months ago (2016-08-12 01:34:28 UTC) #5
noms (inactive)
On 2016/08/12 01:34:28, Dan Beam wrote: > proof i actually tried it ;) > https://bugs.chromium.org/p/chromium/issues/detail?id=637156#c2 ...
4 years, 4 months ago (2016-08-12 04:50:46 UTC) #8
Dan Beam
On 2016/08/12 04:50:46, noms (inactive) wrote: > On 2016/08/12 01:34:28, Dan Beam wrote: > > ...
4 years, 4 months ago (2016-08-12 21:07:01 UTC) #9
noms (inactive)
On 2016/08/12 21:07:01, Dan Beam wrote: > On 2016/08/12 04:50:46, noms (inactive) wrote: > > ...
4 years, 4 months ago (2016-08-12 21:11:22 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2241563003/60001
4 years, 4 months ago (2016-08-12 21:16:29 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/279445)
4 years, 4 months ago (2016-08-12 21:51:55 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2241563003/80001
4 years, 4 months ago (2016-08-12 22:02:31 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/122136)
4 years, 4 months ago (2016-08-13 00:33:36 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2241563003/80001
4 years, 4 months ago (2016-08-15 16:42:57 UTC) #23
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 4 months ago (2016-08-15 16:47:22 UTC) #25
commit-bot: I haz the power
4 years, 4 months ago (2016-08-15 16:49:01 UTC) #27
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/ecbacbc4702091d5e939f1b6aa6acbfc9d3f0664
Cr-Commit-Position: refs/heads/master@{#411973}

Powered by Google App Engine
This is Rietveld 408576698