android: Switch CleanupReference to PhantomReference

android: Switch CleanupReference to PhantomReference

Again. This time due to correctness. Want to experiment on beta to see
how big the impact is. Quoting from the comment in the CL:

NOTE Using PhantonReference instead of WeakReference is required for correctness.
WeakReferences are enqueued before finalizers are called, and finalizers can
resurrect the referent object. PhantomReference does delay clean up more compared
to WeakReference.

BUG=618807
Committed: https://crrev.com/630d88124d2e5a3fda6b9fd25d06eaa1af403fca
Cr-Commit-Position: refs/heads/master@{#411417}

[boliu, 2016-08-11 17:51:44]

Description was changed from

==========
android: Switch CleanupReference to PhantonReference

Again. This time due to correctness. Want to experiment on beta to see
how big the impact is. Quoting from the comment in the CL:

NOTE Using PhantonReference instead of WeakReference is required for
correctness.
WeakReferences are enqueued before finalizers are called, and finalizers can
resurrect the referent object. PhantomReference does delay clean up more
compared
to WeakReference.

BUG=618807
==========

to

==========
android: Switch CleanupReference to PhantomReference

Again. This time due to correctness. Want to experiment on beta to see
how big the impact is. Quoting from the comment in the CL:

NOTE Using PhantonReference instead of WeakReference is required for
correctness.
WeakReferences are enqueued before finalizers are called, and finalizers can
resurrect the referent object. PhantomReference does delay clean up more
compared
to WeakReference.

BUG=618807
==========

[boliu, 2016-08-11 17:51:48]

The CQ bit was checked by boliu@chromium.org to run a CQ dry run

[boliu, 2016-08-11 17:52:12]

boliu@chromium.org changed reviewers:
+ dtrainor@chromium.org

[boliu, 2016-08-11 17:52:12]

Dave are you around to stamp?

[commit-bot: I haz the power, 2016-08-11 17:52:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 19:14:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 19:14:18]

Dry run: This issue passed the CQ dry run.

[boliu, 2016-08-11 19:15:58]

boliu@chromium.org changed reviewers:
+ yfriedman@chromium.org

[boliu, 2016-08-11 19:15:59]

yaron to stamp?

[Yaron, 2016-08-11 20:38:12]

On 2016/08/11 19:15:59, boliu wrote:
> yaron to stamp?

lgtm

[boliu, 2016-08-11 20:40:56]

The CQ bit was checked by boliu@chromium.org

[commit-bot: I haz the power, 2016-08-11 20:41:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 20:45:43]

Description was changed from

==========
android: Switch CleanupReference to PhantomReference

Again. This time due to correctness. Want to experiment on beta to see
how big the impact is. Quoting from the comment in the CL:

NOTE Using PhantonReference instead of WeakReference is required for
correctness.
WeakReferences are enqueued before finalizers are called, and finalizers can
resurrect the referent object. PhantomReference does delay clean up more
compared
to WeakReference.

BUG=618807
==========

to

==========
android: Switch CleanupReference to PhantomReference

Again. This time due to correctness. Want to experiment on beta to see
how big the impact is. Quoting from the comment in the CL:

NOTE Using PhantonReference instead of WeakReference is required for
correctness.
WeakReferences are enqueued before finalizers are called, and finalizers can
resurrect the referent object. PhantomReference does delay clean up more
compared
to WeakReference.

BUG=618807
==========

[commit-bot: I haz the power, 2016-08-11 20:45:44]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-11 20:47:27]

Description was changed from

==========
android: Switch CleanupReference to PhantomReference

Again. This time due to correctness. Want to experiment on beta to see
how big the impact is. Quoting from the comment in the CL:

NOTE Using PhantonReference instead of WeakReference is required for
correctness.
WeakReferences are enqueued before finalizers are called, and finalizers can
resurrect the referent object. PhantomReference does delay clean up more
compared
to WeakReference.

BUG=618807
==========

to

==========
android: Switch CleanupReference to PhantomReference

Again. This time due to correctness. Want to experiment on beta to see
how big the impact is. Quoting from the comment in the CL:

NOTE Using PhantonReference instead of WeakReference is required for
correctness.
WeakReferences are enqueued before finalizers are called, and finalizers can
resurrect the referent object. PhantomReference does delay clean up more
compared
to WeakReference.

BUG=618807

Committed: https://crrev.com/630d88124d2e5a3fda6b9fd25d06eaa1af403fca
Cr-Commit-Position: refs/heads/master@{#411417}
==========

[commit-bot: I haz the power, 2016-08-11 20:47:28]

Patchset 1 (id:??) landed as
https://crrev.com/630d88124d2e5a3fda6b9fd25d06eaa1af403fca
Cr-Commit-Position: refs/heads/master@{#411417}

[boliu, 2016-08-18 16:47:03]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2255253002/ by boliu@chromium.org.

The reason for reverting is: Experiment out. Reverting. See bug for reasoning..