fpdfsdk/javascript/Consts.cpp - Issue 2241483004: Move some v8 objects from CJS back into FXJS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/javascript/Consts.cpp

Issue 2241483004: Move some v8 objects from CJS back into FXJS (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Rename to GetCurrentEngineFromIsolate() since engines not 1:1 with isolates Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/javascript/Consts.cpp

diff --git a/fpdfsdk/javascript/Consts.cpp b/fpdfsdk/javascript/Consts.cpp

index b71d0a34b348b4a2d8f298f2a8d1e747c61579bf..19988a61eaf92ac0c8d393b53d1be5b7779b7e4b 100644

--- a/fpdfsdk/javascript/Consts.cpp

+++ b/fpdfsdk/javascript/Consts.cpp

@@ -148,7 +148,7 @@ void CJS_GlobalConsts::DefineJSObjects(CJS_Runtime* pRuntime) {

(rt)->GetIsolate(), (name), \

[](const v8::FunctionCallbackInfo<v8::Value>& info) { \

CJS_Runtime* pLocalRuntime = static_cast<CJS_Runtime*>( \

- FXJS_GetRuntimeFromIsolate(info.GetIsolate())); \

+ FXJS_GetCurrentEngineFromIsolate(info.GetIsolate())); \

if (pLocalRuntime) \

info.GetReturnValue().Set(pLocalRuntime->GetConstArray(name)); \

}); \

« no previous file with comments | « no previous file | fpdfsdk/javascript/JS_Define.h » ('j') | no next file with comments »