Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2241433002: cipd: drop unneeded dependency on the file recipe module (Closed)

Created:
4 years, 4 months ago by Paweł Hajdan Jr.
Modified:
4 years, 4 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

cipd: drop unneeded dependency on the file recipe module This makes it clear cipd module could be easily moved to depot_tools. BUG=635421, 629679 Committed: https://chromium.googlesource.com/chromium/tools/build/+/2df96279adf5abf895e63b609c7683d33b941862

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M scripts/slave/recipe_modules/cipd/__init__.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
Paweł Hajdan Jr.
4 years, 4 months ago (2016-08-11 14:07:22 UTC) #2
Michael Achenbach
lgtm
4 years, 4 months ago (2016-08-11 14:15:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2241433002/1
4 years, 4 months ago (2016-08-11 14:18:37 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 14:22:15 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/2df96279adf5abf895e6...

Powered by Google App Engine
This is Rietveld 408576698